[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy: Set UPD CmdTriStateDis for Atlas

Caveh Jalali (Code Review) gerrit at coreboot.org
Sat Sep 8 02:44:44 CEST 2018


Hello caveh jalali,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/28540

to review the following change.


Change subject: mb/google/poppy: Set UPD CmdTriStateDis for Atlas
......................................................................

mb/google/poppy: Set UPD CmdTriStateDis for Atlas

This patch sets the MRC UPD CmdTriStateDis for the atlas boards.
Atlas is a LPDDR3 design without RTT for CMD/CTRL.

The original change for
nocturne is I0f593761dcbd121e7e758421af178931b9d78295

BUG=b:111812662

Change-Id: I45b6dd22412c689c8db64f4650e9fa9e87dec2ec
Signed-off-by: Caveh Jalali <caveh at chromium.org>
---
M src/mainboard/google/poppy/variants/atlas/devicetree.cb
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/28540/1

diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb
index 968faef..dc54099 100644
--- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb
@@ -27,6 +27,9 @@
 	# Enable S0ix
 	register "s0ix_enable" = "1"
 
+	# Disable Command TriState
+	register "CmdTriStateDis" = "1"
+
 	# FSP Configuration
 	register "ProbelessTrace" = "0"
 	register "EnableLan" = "0"

-- 
To view, visit https://review.coreboot.org/28540
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45b6dd22412c689c8db64f4650e9fa9e87dec2ec
Gerrit-Change-Number: 28540
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: caveh jalali <caveh at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180908/9848cc2b/attachment.html>


More information about the coreboot-gerrit mailing list