[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: Reset trackpad & touchscreen

Martin Roth (Code Review) gerrit at coreboot.org
Fri Sep 7 19:29:13 CEST 2018


Martin Roth has uploaded this change for review. ( https://review.coreboot.org/28538


Change subject: mainboard/google/kahlee: Reset trackpad & touchscreen
......................................................................

mainboard/google/kahlee: Reset trackpad & touchscreen

AMD chips don't hold off a reset to the end of I2c transitions, so
devices on the i2c bus can be left in a bad state.  To avoid this,
make sure the trackpad and touchscreen chips get disabled
during boot.

BUG=b:114411165
TEST=build, reboot watch trackpad enable go low

Change-Id: Ie50f4a102249df79517da571a6e768dba804cd57
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/google/kahlee/variants/baseboard/gpio.c
1 file changed, 8 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/28538/1

diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
index 66d5c99..75a8ab5 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c
+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
@@ -40,6 +40,10 @@
 	/* GPIO_15 - EC_IN_RW_OD */
 	PAD_GPI(GPIO_15, PULL_UP),
 
+	/* GPIO_12 - EN_PP3300_TRACKPAD */
+	/* Init low to reset the chip */
+	PAD_GPO(GPIO_12, LOW),
+
 	/* GPIO_22 - EC_SCI_ODL, SCI */
 	PAD_SCI(GPIO_22, PULL_UP, EDGE_LOW),
 
@@ -58,6 +62,10 @@
 	/* GPIO_74 - LPC_CLK0_EC_R */
 	PAD_NF(GPIO_74, LPCCLK0, PULL_DOWN),
 
+	/* GPIO_76 - EN_PP3300_TOUCHSCREEN */
+	/* Init low to reset the chip */
+	PAD_GPO(GPIO_76, LOW),
+
 	/* GPIO_92 - WLAN_PCIE_CLKREQ_3V3_ODL */
 	PAD_NF(GPIO_92, CLK_REQ0_L, PULL_UP),
 

-- 
To view, visit https://review.coreboot.org/28538
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie50f4a102249df79517da571a6e768dba804cd57
Gerrit-Change-Number: 28538
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180907/188d72c5/attachment-0001.html>


More information about the coreboot-gerrit mailing list