[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Construct BERT region from machine check

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28477 )

Change subject: amd/stoneyridge: Construct BERT region from machine check
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/28477/2/src/soc/amd/stoneyridge/mca.c
File src/soc/amd/stoneyridge/mca.c:

https://review.coreboot.org/#/c/28477/2/src/soc/amd/stoneyridge/mca.c@47
PS2, Line 47: 1 * 
?


https://review.coreboot.org/#/c/28477/2/src/soc/amd/stoneyridge/mca.c@117
PS2, Line 117: 	if (!IS_ENABLED(CONFIG_ACPI_BERT))
             : 		return;
why put this here instead of around the call?


https://review.coreboot.org/#/c/28477/2/src/soc/amd/stoneyridge/mca.c@141
PS2, Line 141: goto failed;
Can we end up with a half-filled-in table?  Will that cause issues on the reporting side?  Would it be better to generate it somewhere else, then copy the full entry into the table if there's size?



-- 
To view, visit https://review.coreboot.org/28477
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d4ce29ddefa22aa29e6d3184f1adeaea1d5f837
Gerrit-Change-Number: 28477
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Thu, 06 Sep 2018 02:14:36 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180906/d495057f/attachment.html>