<p><a href="https://review.coreboot.org/28477">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28477/2/src/soc/amd/stoneyridge/mca.c">File src/soc/amd/stoneyridge/mca.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28477/2/src/soc/amd/stoneyridge/mca.c@47">Patch Set #2, Line 47:</a> <code style="font-family:monospace,monospace">1 * </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28477/2/src/soc/amd/stoneyridge/mca.c@117">Patch Set #2, Line 117:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">    if (!IS_ENABLED(CONFIG_ACPI_BERT))<br>            return;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">why put this here instead of around the call?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28477/2/src/soc/amd/stoneyridge/mca.c@141">Patch Set #2, Line 141:</a> <code style="font-family:monospace,monospace">goto failed;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Can we end up with a half-filled-in table?  Will that cause issues on the reporting side?  Would it be better to generate it somewhere else, then copy the full entry into the table if there's size?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28477">change 28477</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28477"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I4d4ce29ddefa22aa29e6d3184f1adeaea1d5f837 </div>
<div style="display:none"> Gerrit-Change-Number: 28477 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 06 Sep 2018 02:14:36 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>