[coreboot-gerrit] Change in coreboot[master]: arch/x86: Add BERT region support functions

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28470 )

Change subject: arch/x86: Add BERT region support functions
......................................................................


Patch Set 2:

(4 comments)

https://review.coreboot.org/#/c/28470/2/src/arch/x86/acpi_bert_storage.c
File src/arch/x86/acpi_bert_storage.c:

https://review.coreboot.org/#/c/28470/2/src/arch/x86/acpi_bert_storage.c@350
PS2, Line 350: 3
is this CPER_IA32X64_CTX_64BIT_EX?


https://review.coreboot.org/#/c/28470/2/src/arch/x86/acpi_bert_storage.c@399
PS2, Line 399: cpuid_eax
use "struct cpuid_result" and cpuid() instead of calling cpuid 4 times?


https://review.coreboot.org/#/c/28470/2/src/arch/x86/acpi_bert_storage.c@519
PS2, Line 519: 	*start = NULL;
Add a printf stating that the weak function was called and that a full implementation must be added?

 printk(BIOS_ERR, "Error: %s not implemented.  BERT region generation disabled", __func__);


https://review.coreboot.org/#/c/28470/2/src/arch/x86/include/arch/bert_storage.h
File src/arch/x86/include/arch/bert_storage.h:

https://review.coreboot.org/#/c/28470/2/src/arch/x86/include/arch/bert_storage.h@88
PS2, Line 88: acpi_hest_generic_data_nth
Why make this inline?



-- 
To view, visit https://review.coreboot.org/28470
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54826981639b5647a8ca33b8b55ff097681402b9
Gerrit-Change-Number: 28470
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Thu, 06 Sep 2018 01:40:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180906/8f83cfe5/attachment.html>