<p><a href="https://review.coreboot.org/28470">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28470/2/src/arch/x86/acpi_bert_storage.c">File src/arch/x86/acpi_bert_storage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28470/2/src/arch/x86/acpi_bert_storage.c@350">Patch Set #2, Line 350:</a> <code style="font-family:monospace,monospace">3</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">is this CPER_IA32X64_CTX_64BIT_EX?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28470/2/src/arch/x86/acpi_bert_storage.c@399">Patch Set #2, Line 399:</a> <code style="font-family:monospace,monospace">cpuid_eax</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">use "struct cpuid_result" and cpuid() instead of calling cpuid 4 times?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28470/2/src/arch/x86/acpi_bert_storage.c@519">Patch Set #2, Line 519:</a> <code style="font-family:monospace,monospace">    *start = NULL;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add a printf stating that the weak function was called and that a full implementation must be added?</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> printk(BIOS_ERR, "Error: %s not implemented.  BERT region generation disabled", __func__);</pre></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28470/2/src/arch/x86/include/arch/bert_storage.h">File src/arch/x86/include/arch/bert_storage.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28470/2/src/arch/x86/include/arch/bert_storage.h@88">Patch Set #2, Line 88:</a> <code style="font-family:monospace,monospace">acpi_hest_generic_data_nth</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why make this inline?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28470">change 28470</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28470"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I54826981639b5647a8ca33b8b55ff097681402b9 </div>
<div style="display:none"> Gerrit-Change-Number: 28470 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 06 Sep 2018 01:40:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>