[coreboot-gerrit] Change in coreboot[master]: nocturne: Do not send eSPI interrupt for MKBP events

[Enrico Granata (Code Review)]

Enrico Granata has uploaded this change for review. ( https://review.coreboot.org/28524


Change subject: nocturne: Do not send eSPI interrupt for MKBP events
......................................................................

nocturne: Do not send eSPI interrupt for MKBP events

On Nocturne, we plan to use the GPIO IRQ as the means of communicating MKBP
event information from the EC. On such hardware, do not send the MKBP eSPI
interrupt.

Change-Id: I7e7f5def9dbc170913d67dca7c7cc12da8c4efbb
Signed-off-by: Enrico Granata <egranata at chromium.org>
---
M src/ec/google/chromeec/acpi/ec.asl
M src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h
2 files changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/28524/1

diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl
index 453a6d7..4b77604 100644
--- a/src/ec/google/chromeec/acpi/ec.asl
+++ b/src/ec/google/chromeec/acpi/ec.asl
@@ -362,8 +362,10 @@
 	// MKBP interrupt.
 	Method (_Q1B, 0, NotSerialized)
 	{
+#ifndef EC_NO_MKBP_SYNC_NOTIFY
 		Store ("EC: MKBP", Debug)
 		Notify (CREC, 0x80)
+#endif
 	}
 
 	// TABLET mode switch Event
diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h b/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h
index 7e16801..be81fec 100644
--- a/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h
+++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h
@@ -79,4 +79,6 @@
 #define EC_ENABLE_MKBP_DEVICE  /* Enable cros_ec_keyb device */
 #define EC_ENABLE_CBAS_DEVICE  /* Enable "Base Attached Switch" device */
 
+#define EC_NO_MKBP_SYNC_NOTIFY /* Do not send eSPI interrupt for MKBP event */
+
 #endif /* __MAINBOARD_EC_H__ */

-- 
To view, visit https://review.coreboot.org/28524
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e7f5def9dbc170913d67dca7c7cc12da8c4efbb
Gerrit-Change-Number: 28524
Gerrit-PatchSet: 1
Gerrit-Owner: Enrico Granata <egranata at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180906/c45708bd/attachment.html>