<p>Enrico Granata has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28524">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nocturne: Do not send eSPI interrupt for MKBP events<br><br>On Nocturne, we plan to use the GPIO IRQ as the means of communicating MKBP<br>event information from the EC. On such hardware, do not send the MKBP eSPI<br>interrupt.<br><br>Change-Id: I7e7f5def9dbc170913d67dca7c7cc12da8c4efbb<br>Signed-off-by: Enrico Granata <egranata@chromium.org><br>---<br>M src/ec/google/chromeec/acpi/ec.asl<br>M src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h<br>2 files changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/28524/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl</span><br><span>index 453a6d7..4b77604 100644</span><br><span>--- a/src/ec/google/chromeec/acpi/ec.asl</span><br><span>+++ b/src/ec/google/chromeec/acpi/ec.asl</span><br><span>@@ -362,8 +362,10 @@</span><br><span>        // MKBP interrupt.</span><br><span>   Method (_Q1B, 0, NotSerialized)</span><br><span>      {</span><br><span style="color: hsl(120, 100%, 40%);">+#ifndef EC_NO_MKBP_SYNC_NOTIFY</span><br><span>            Store ("EC: MKBP", Debug)</span><br><span>          Notify (CREC, 0x80)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span>  }</span><br><span> </span><br><span>        // TABLET mode switch Event</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h b/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h</span><br><span>index 7e16801..be81fec 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h</span><br><span>@@ -79,4 +79,6 @@</span><br><span> #define EC_ENABLE_MKBP_DEVICE  /* Enable cros_ec_keyb device */</span><br><span> #define EC_ENABLE_CBAS_DEVICE  /* Enable "Base Attached Switch" device */</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#define EC_NO_MKBP_SYNC_NOTIFY /* Do not send eSPI interrupt for MKBP event */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #endif /* __MAINBOARD_EC_H__ */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28524">change 28524</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28524"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7e7f5def9dbc170913d67dca7c7cc12da8c4efbb </div>
<div style="display:none"> Gerrit-Change-Number: 28524 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Enrico Granata <egranata@chromium.org> </div>