[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Add support for CmdTriStateDis UPD in devicetree

Shaunak Saha (Code Review) gerrit at coreboot.org
Tue Sep 4 20:44:03 CEST 2018


Shaunak Saha has uploaded a new patch set (#2). ( https://review.coreboot.org/28424 )

Change subject: soc/intel/skylake: Add support for CmdTriStateDis UPD in devicetree
......................................................................

soc/intel/skylake: Add support for CmdTriStateDis UPD in devicetree

This patch adds the support for CmdTriStateDis FSP upd in skylake
soc structure so that we can define it in devicetree.CmdTriStateDis
needed to be set for the skylake/kabylake based boards where LPDDR3
design is without RTT for CMD/CTRL.We need to set this bit for those
designs for the margin to be proper.

BUG=b:111812662
TEST=Run memtester app and also webgl fishtank on
     the LPDDR3 kabylake boards and also check the
     margin data is proper in FSP.

Change-Id: Ida69e443aa6ea4b524bd3ea2dcf26f4e63010291
Signed-off-by: Shaunak Saha <shaunak.saha at intel.com>
---
M src/soc/intel/skylake/chip.h
M src/soc/intel/skylake/romstage/romstage_fsp20.c
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/28424/2
-- 
To view, visit https://review.coreboot.org/28424
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida69e443aa6ea4b524bd3ea2dcf26f4e63010291
Gerrit-Change-Number: 28424
Gerrit-PatchSet: 2
Gerrit-Owner: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180904/aad2f559/attachment.html>


More information about the coreboot-gerrit mailing list