[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Add support for CmdTriStateDis UPD in devicetree

[Shaunak Saha (Code Review)]

Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/28424 )

Change subject: soc/intel/skylake: Add support for CmdTriStateDis UPD in devicetree
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/28424/1/src/soc/intel/skylake/chip.h
File src/soc/intel/skylake/chip.h:

https://review.coreboot.org/#/c/28424/1/src/soc/intel/skylake/chip.h@157
PS1, Line 157: Enable/disable
> Just say "Disable" since this config is used to basically disable command tristate?
Ack



-- 
To view, visit https://review.coreboot.org/28424
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida69e443aa6ea4b524bd3ea2dcf26f4e63010291
Gerrit-Change-Number: 28424
Gerrit-PatchSet: 1
Gerrit-Owner: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
Gerrit-Comment-Date: Tue, 04 Sep 2018 18:18:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180904/cd854649/attachment.html>