[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8183: Add MediaTek DDR driver

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28437 )

Change subject: mediatek/mt8183: Add MediaTek DDR driver
......................................................................


Patch Set 1:

(7 comments)

https://review.coreboot.org/#/c/28437/1/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c
File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:

https://review.coreboot.org/#/c/28437/1/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c@276
PS1, Line 276: 	for (size_t i = 0; i < DQS_NUMBER; i++) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/28437/1/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c@862
PS1, Line 862: 	dramc_dbg("[dramc_rx_dqs_gating_cal] Done\n\n");
Prefer using '"%s...", __func__' to using 'dramc_rx_dqs_gating_cal', this function's name, in a string


https://review.coreboot.org/#/c/28437/1/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c@1033
PS1, Line 1033: 	if(rank == RANK_0)
space required before the open parenthesis '('


https://review.coreboot.org/#/c/28437/1/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c@1627
PS1, Line 1627: 			(read32(&ch[chn].ao.shu[0].selph_dqs0) >> (i << 2)) & 0x7;
line over 80 characters


https://review.coreboot.org/#/c/28437/1/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c@1629
PS1, Line 1629: 			(read32(&ch[chn].ao.shu[0].selph_dqs1) >> (i << 2)) & 0x7;
line over 80 characters


https://review.coreboot.org/#/c/28437/1/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c@1632
PS1, Line 1632: 			(((dq_coarse_dly << 3) + dq_fine_dly) << 5) + params->wr_level[chn][rank][i];
line over 80 characters


https://review.coreboot.org/#/c/28437/1/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c@1942
PS1, Line 1942: 				bit, dqdqs_perbit_dly[bit].best_first_dqdly_pass,
line over 80 characters



-- 
To view, visit https://review.coreboot.org/28437
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaa1db170c168a58b020095ae45d98355d8dfcb0
Gerrit-Change-Number: 28437
Gerrit-PatchSet: 1
Gerrit-Owner: Tristan Hsieh <tristan.shieh at mediatek.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 03 Sep 2018 03:51:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180903/b26782e2/attachment.html>