<p><a href="https://review.coreboot.org/28437">View Change</a></p><p>7 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28437/1/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c">File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28437/1/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c@276">Patch Set #1, Line 276:</a> <code style="font-family:monospace,monospace"> for (size_t i = 0; i < DQS_NUMBER; i++) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28437/1/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c@862">Patch Set #1, Line 862:</a> <code style="font-family:monospace,monospace">    dramc_dbg("[dramc_rx_dqs_gating_cal] Done\n\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer using '"%s...", __func__' to using 'dramc_rx_dqs_gating_cal', this function's name, in a string</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28437/1/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c@1033">Patch Set #1, Line 1033:</a> <code style="font-family:monospace,monospace">       if(rank == RANK_0)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28437/1/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c@1627">Patch Set #1, Line 1627:</a> <code style="font-family:monospace,monospace">                     (read32(&ch[chn].ao.shu[0].selph_dqs0) >> (i << 2)) & 0x7;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28437/1/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c@1629">Patch Set #1, Line 1629:</a> <code style="font-family:monospace,monospace">                        (read32(&ch[chn].ao.shu[0].selph_dqs1) >> (i << 2)) & 0x7;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28437/1/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c@1632">Patch Set #1, Line 1632:</a> <code style="font-family:monospace,monospace">                        (((dq_coarse_dly << 3) + dq_fine_dly) << 5) + params->wr_level[chn][rank][i];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28437/1/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c@1942">Patch Set #1, Line 1942:</a> <code style="font-family:monospace,monospace">                          bit, dqdqs_perbit_dly[bit].best_first_dqdly_pass,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28437">change 28437</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28437"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iaaa1db170c168a58b020095ae45d98355d8dfcb0 </div>
<div style="display:none"> Gerrit-Change-Number: 28437 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Tristan Hsieh <tristan.shieh@mediatek.com> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 03 Sep 2018 03:51:45 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>