[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/rammus: add sku info into smbios table

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/28426 )

Change subject: mb/google/poppy/variants/rammus: add sku info into smbios table
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/28426/1/src/mainboard/google/poppy/variants/rammus/include/variant/sku.h
File src/mainboard/google/poppy/variants/rammus/include/variant/sku.h:

https://review.coreboot.org/#/c/28426/1/src/mainboard/google/poppy/variants/rammus/include/variant/sku.h@19
PS1, Line 19: #define SKU_UNKNOWN	0xFFFFFFFF
Are you expecting this will be used outside mainboard.c? Else it can live in the .c file?



-- 
To view, visit https://review.coreboot.org/28426
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3413784cca1ac10a2468d84f2d06c0e1d701fdcb
Gerrit-Change-Number: 28426
Gerrit-PatchSet: 1
Gerrit-Owner: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 01 Sep 2018 17:42:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180901/123d7ae4/attachment.html>