[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/rammus: add sku info into smbios table

Zhuohao Lee (Code Review) gerrit at coreboot.org
Sat Sep 1 11:55:29 CEST 2018


Zhuohao Lee has uploaded this change for review. ( https://review.coreboot.org/28426


Change subject: mb/google/poppy/variants/rammus: add sku info into smbios table
......................................................................

mb/google/poppy/variants/rammus: add sku info into smbios table

This patch adds the mainboard.c in order to support the sku id in smbios
table where the sku id is queried from the eeprom via EC.

BUG=b:113714761
BRANCH=master
TEST=check the result of 'dmidecode'

Change-Id: I3413784cca1ac10a2468d84f2d06c0e1d701fdcb
Signed-off-by: Zhuohao Lee <zhuohao at chromium.org>
---
M src/mainboard/google/poppy/variants/rammus/Makefile.inc
A src/mainboard/google/poppy/variants/rammus/include/variant/sku.h
A src/mainboard/google/poppy/variants/rammus/mainboard.c
3 files changed, 65 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/28426/1

diff --git a/src/mainboard/google/poppy/variants/rammus/Makefile.inc b/src/mainboard/google/poppy/variants/rammus/Makefile.inc
index eed7c44..9db2c21 100644
--- a/src/mainboard/google/poppy/variants/rammus/Makefile.inc
+++ b/src/mainboard/google/poppy/variants/rammus/Makefile.inc
@@ -6,3 +6,4 @@
 
 ramstage-y += gpio.c
 ramstage-y += nhlt.c
+ramstage-y += mainboard.c
diff --git a/src/mainboard/google/poppy/variants/rammus/include/variant/sku.h b/src/mainboard/google/poppy/variants/rammus/include/variant/sku.h
new file mode 100644
index 0000000..9ed3a0f
--- /dev/null
+++ b/src/mainboard/google/poppy/variants/rammus/include/variant/sku.h
@@ -0,0 +1,21 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 Google Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __MAINBOARD_SKU_H__
+#define __MAINBOARD_SKU_H__
+
+#define SKU_UNKNOWN	0xFFFFFFFF
+
+#endif /* __MAINBOARD_SKU_H__ */
diff --git a/src/mainboard/google/poppy/variants/rammus/mainboard.c b/src/mainboard/google/poppy/variants/rammus/mainboard.c
new file mode 100644
index 0000000..eb64ddf
--- /dev/null
+++ b/src/mainboard/google/poppy/variants/rammus/mainboard.c
@@ -0,0 +1,43 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 Google Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <baseboard/variants.h>
+#include <ec/google/chromeec/ec.h>
+#include <smbios.h>
+#include <string.h>
+#include <variant/sku.h>
+
+uint32_t variant_board_sku(void)
+{
+	static uint32_t sku_id = SKU_UNKNOWN;
+	uint32_t id;
+
+	if (sku_id != SKU_UNKNOWN)
+		return sku_id;
+	if (google_chromeec_cbi_get_sku_id(&id))
+		return SKU_UNKNOWN;
+	sku_id = id;
+
+	return sku_id;
+}
+
+const char *smbios_mainboard_sku(void)
+{
+	static char sku_str[14]; /* sku{0..4294967295} */
+
+	snprintf(sku_str, sizeof(sku_str), "sku%u", variant_board_sku());
+
+	return sku_str;
+}

-- 
To view, visit https://review.coreboot.org/28426
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3413784cca1ac10a2468d84f2d06c0e1d701fdcb
Gerrit-Change-Number: 28426
Gerrit-PatchSet: 1
Gerrit-Owner: Zhuohao Lee <zhuohao at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180901/984c1f7c/attachment-0001.html>


More information about the coreboot-gerrit mailing list