[coreboot-gerrit] Change in coreboot[master]: nb/intel/haswell/gma: Support boards that have DDI E connected

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/29385 )

Change subject: nb/intel/haswell/gma: Support boards that have DDI E connected
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/29385/1/src/northbridge/intel/haswell/chip.h
File src/northbridge/intel/haswell/chip.h:

https://review.coreboot.org/#/c/29385/1/src/northbridge/intel/haswell/chip.h@43
PS1, Line 43: connected
Not sure if `connected` is the right word here (could be confused
with a display being connected). Maybe `_used` or `_enabled`?



-- 
To view, visit https://review.coreboot.org/29385
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f7832293215d2b53e31b0a5c985e6098eb72f1b
Gerrit-Change-Number: 29385
Gerrit-PatchSet: 1
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Wed, 31 Oct 2018 13:05:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181031/c8ebf9be/attachment.html>