[coreboot-gerrit] Change in coreboot[master]: mb/google/kahlee: Disable IOMMU

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/29342 )

Change subject: mb/google/kahlee: Disable IOMMU
......................................................................

mb/google/kahlee: Disable IOMMU

Unfortunately Stoney has an issue where enabling the IOMMU causes
a 10%-50% decrease in the integrated graphics performance.  It is
also disabled by default on other stoney platforms.

BUG=b:118612241
TEST=Verify that IOMMU is disabled.

Change-Id: Ia396c7227cb21461ec8afbdf746721d4fb28083d
Signed-off-by: Martin Roth <martinroth at google.com>
Reviewed-on: https://review.coreboot.org/29342
Reviewed-by: Raul Rangel <rrangel at chromium.org>
Reviewed-by: Daniel Kurtz <djkurtz at google.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/mainboard/google/kahlee/variants/aleena/devicetree.cb
M src/mainboard/google/kahlee/variants/careena/devicetree.cb
M src/mainboard/google/kahlee/variants/delan/devicetree.cb
M src/mainboard/google/kahlee/variants/grunt/devicetree.cb
M src/mainboard/google/kahlee/variants/liara/devicetree.cb
5 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Daniel Kurtz: Looks good to me, approved
  Raul Rangel: Looks good to me, approved



diff --git a/src/mainboard/google/kahlee/variants/aleena/devicetree.cb b/src/mainboard/google/kahlee/variants/aleena/devicetree.cb
index 5438e6d..27a8e28 100644
--- a/src/mainboard/google/kahlee/variants/aleena/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/aleena/devicetree.cb
@@ -58,7 +58,7 @@
 	end
 	device domain 0 on
 		device pci 0.0 on  end # Root Complex
-		device pci 0.2 on  end # IOMMU
+		device pci 0.2 off end # IOMMU (Disabled for performance and battery)
 		device pci 1.0 on  end # Internal Graphics P2P bridge 0x98e4
 		device pci 1.1 on  end # Internal Multimedia
 		device pci 2.0 on  end # PCIe Host Bridge
diff --git a/src/mainboard/google/kahlee/variants/careena/devicetree.cb b/src/mainboard/google/kahlee/variants/careena/devicetree.cb
index b541c03..23253b2 100644
--- a/src/mainboard/google/kahlee/variants/careena/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/careena/devicetree.cb
@@ -61,7 +61,7 @@
 	end
 	device domain 0 on
 		device pci 0.0 on  end # Root Complex
-		device pci 0.2 on  end # IOMMU
+		device pci 0.2 off end # IOMMU (Disabled for performance and battery)
 		device pci 1.0 on  end # Internal Graphics P2P bridge 0x98e4
 		device pci 1.1 on  end # Internal Multimedia
 		device pci 2.0 on  end # PCIe Host Bridge
diff --git a/src/mainboard/google/kahlee/variants/delan/devicetree.cb b/src/mainboard/google/kahlee/variants/delan/devicetree.cb
index 0dfe204..fd30d5d 100644
--- a/src/mainboard/google/kahlee/variants/delan/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/delan/devicetree.cb
@@ -55,7 +55,7 @@
 	end
 	device domain 0 on
 		device pci 0.0 on  end # Root Complex
-		device pci 0.2 on  end # IOMMU
+		device pci 0.2 off end # IOMMU (Disabled for performance and battery)
 		device pci 1.0 on  end # Internal Graphics P2P bridge 0x98e4
 		device pci 1.1 on  end # Internal Multimedia
 		device pci 2.0 on  end # PCIe Host Bridge
diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
index 5a8906b..b37e1bf 100644
--- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb
@@ -61,7 +61,7 @@
 	end
 	device domain 0 on
 		device pci 0.0 on  end # Root Complex
-		device pci 0.2 on  end # IOMMU
+		device pci 0.2 off end # IOMMU (Disabled for performance and battery)
 		device pci 1.0 on  end # Internal Graphics P2P bridge 0x98e4
 		device pci 1.1 on  end # Internal Multimedia
 		device pci 2.0 on  end # PCIe Host Bridge
diff --git a/src/mainboard/google/kahlee/variants/liara/devicetree.cb b/src/mainboard/google/kahlee/variants/liara/devicetree.cb
index cea3425..343fbeb 100644
--- a/src/mainboard/google/kahlee/variants/liara/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/liara/devicetree.cb
@@ -58,7 +58,7 @@
 	end
 	device domain 0 on
 		device pci 0.0 on  end # Root Complex
-		device pci 0.2 on  end # IOMMU
+		device pci 0.2 off end # IOMMU
 		device pci 1.0 on  end # Internal Graphics P2P bridge 0x98e4
 		device pci 1.1 on  end # Internal Multimedia
 		device pci 2.0 on  end # PCIe Host Bridge

-- 
To view, visit https://review.coreboot.org/29342
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia396c7227cb21461ec8afbdf746721d4fb28083d
Gerrit-Change-Number: 29342
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181030/17e2909f/attachment.html>