<p>Martin Roth <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/29342">View Change</a></p><div style="white-space:pre-wrap">Approvals:
build bot (Jenkins): Verified
Daniel Kurtz: Looks good to me, approved
Raul Rangel: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/kahlee: Disable IOMMU<br><br>Unfortunately Stoney has an issue where enabling the IOMMU causes<br>a 10%-50% decrease in the integrated graphics performance. It is<br>also disabled by default on other stoney platforms.<br><br>BUG=b:118612241<br>TEST=Verify that IOMMU is disabled.<br><br>Change-Id: Ia396c7227cb21461ec8afbdf746721d4fb28083d<br>Signed-off-by: Martin Roth <martinroth@google.com><br>Reviewed-on: https://review.coreboot.org/29342<br>Reviewed-by: Raul Rangel <rrangel@chromium.org><br>Reviewed-by: Daniel Kurtz <djkurtz@google.com><br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>---<br>M src/mainboard/google/kahlee/variants/aleena/devicetree.cb<br>M src/mainboard/google/kahlee/variants/careena/devicetree.cb<br>M src/mainboard/google/kahlee/variants/delan/devicetree.cb<br>M src/mainboard/google/kahlee/variants/grunt/devicetree.cb<br>M src/mainboard/google/kahlee/variants/liara/devicetree.cb<br>5 files changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/variants/aleena/devicetree.cb b/src/mainboard/google/kahlee/variants/aleena/devicetree.cb</span><br><span>index 5438e6d..27a8e28 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/aleena/devicetree.cb</span><br><span>+++ b/src/mainboard/google/kahlee/variants/aleena/devicetree.cb</span><br><span>@@ -58,7 +58,7 @@</span><br><span> end</span><br><span> device domain 0 on</span><br><span> device pci 0.0 on end # Root Complex</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 0.2 on end # IOMMU</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 0.2 off end # IOMMU (Disabled for performance and battery)</span><br><span> device pci 1.0 on end # Internal Graphics P2P bridge 0x98e4</span><br><span> device pci 1.1 on end # Internal Multimedia</span><br><span> device pci 2.0 on end # PCIe Host Bridge</span><br><span>diff --git a/src/mainboard/google/kahlee/variants/careena/devicetree.cb b/src/mainboard/google/kahlee/variants/careena/devicetree.cb</span><br><span>index b541c03..23253b2 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/careena/devicetree.cb</span><br><span>+++ b/src/mainboard/google/kahlee/variants/careena/devicetree.cb</span><br><span>@@ -61,7 +61,7 @@</span><br><span> end</span><br><span> device domain 0 on</span><br><span> device pci 0.0 on end # Root Complex</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 0.2 on end # IOMMU</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 0.2 off end # IOMMU (Disabled for performance and battery)</span><br><span> device pci 1.0 on end # Internal Graphics P2P bridge 0x98e4</span><br><span> device pci 1.1 on end # Internal Multimedia</span><br><span> device pci 2.0 on end # PCIe Host Bridge</span><br><span>diff --git a/src/mainboard/google/kahlee/variants/delan/devicetree.cb b/src/mainboard/google/kahlee/variants/delan/devicetree.cb</span><br><span>index 0dfe204..fd30d5d 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/delan/devicetree.cb</span><br><span>+++ b/src/mainboard/google/kahlee/variants/delan/devicetree.cb</span><br><span>@@ -55,7 +55,7 @@</span><br><span> end</span><br><span> device domain 0 on</span><br><span> device pci 0.0 on end # Root Complex</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 0.2 on end # IOMMU</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 0.2 off end # IOMMU (Disabled for performance and battery)</span><br><span> device pci 1.0 on end # Internal Graphics P2P bridge 0x98e4</span><br><span> device pci 1.1 on end # Internal Multimedia</span><br><span> device pci 2.0 on end # PCIe Host Bridge</span><br><span>diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb</span><br><span>index 5a8906b..b37e1bf 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb</span><br><span>+++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb</span><br><span>@@ -61,7 +61,7 @@</span><br><span> end</span><br><span> device domain 0 on</span><br><span> device pci 0.0 on end # Root Complex</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 0.2 on end # IOMMU</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 0.2 off end # IOMMU (Disabled for performance and battery)</span><br><span> device pci 1.0 on end # Internal Graphics P2P bridge 0x98e4</span><br><span> device pci 1.1 on end # Internal Multimedia</span><br><span> device pci 2.0 on end # PCIe Host Bridge</span><br><span>diff --git a/src/mainboard/google/kahlee/variants/liara/devicetree.cb b/src/mainboard/google/kahlee/variants/liara/devicetree.cb</span><br><span>index cea3425..343fbeb 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/liara/devicetree.cb</span><br><span>+++ b/src/mainboard/google/kahlee/variants/liara/devicetree.cb</span><br><span>@@ -58,7 +58,7 @@</span><br><span> end</span><br><span> device domain 0 on</span><br><span> device pci 0.0 on end # Root Complex</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 0.2 on end # IOMMU</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 0.2 off end # IOMMU</span><br><span> device pci 1.0 on end # Internal Graphics P2P bridge 0x98e4</span><br><span> device pci 1.1 on end # Internal Multimedia</span><br><span> device pci 2.0 on end # PCIe Host Bridge</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29342">change 29342</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29342"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ia396c7227cb21461ec8afbdf746721d4fb28083d </div>
<div style="display:none"> Gerrit-Change-Number: 29342 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marc Jones <marc@marcjonesconsulting.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>