[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy: adjust RcompTarget to fix DRAM corruption

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/29360 )

Change subject: mb/google/poppy: adjust RcompTarget to fix DRAM corruption
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29360/1/src/mainboard/google/poppy/romstage.c
File src/mainboard/google/poppy/romstage.c:

https://review.coreboot.org/#/c/29360/1/src/mainboard/google/poppy/romstage.c@173
PS1, Line 173: 	mem_cfg->RcompTarget[1] = 30;
This should be changed here https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/poppy/variants/nocturne/memory.c?id=refs/heads/master#n35 and not in common poppy code.



-- 
To view, visit https://review.coreboot.org/29360
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7404b1fba3cd859b714e772287ee74be6d53dd30
Gerrit-Change-Number: 29360
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
Gerrit-Comment-Date: Tue, 30 Oct 2018 18:31:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181030/b3c3d2a1/attachment.html>