<p><a href="https://review.coreboot.org/29360">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29360/1/src/mainboard/google/poppy/romstage.c">File src/mainboard/google/poppy/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29360/1/src/mainboard/google/poppy/romstage.c@173">Patch Set #1, Line 173:</a> <code style="font-family:monospace,monospace"> mem_cfg->RcompTarget[1] = 30;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should be changed here https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/poppy/variants/nocturne/memory.c?id=refs/heads/master#n35 and not in common poppy code.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29360">change 29360</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29360"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I7404b1fba3cd859b714e772287ee74be6d53dd30 </div>
<div style="display:none"> Gerrit-Change-Number: 29360 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nick Vaccaro <nvaccaro@google.com> </div>
<div style="display:none"> Gerrit-CC: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 30 Oct 2018 18:31:21 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>