[coreboot-gerrit] Change in coreboot[master]: src/soc/intel/braswell/northcluster.c: Correct calculation of FSP mem...

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29333 )

Change subject: src/soc/intel/braswell/northcluster.c: Correct calculation of FSP memory area
......................................................................


Patch Set 3:

(4 comments)

https://review.coreboot.org/#/c/29333/3/src/soc/intel/braswell/northcluster.c
File src/soc/intel/braswell/northcluster.c:

https://review.coreboot.org/#/c/29333/3/src/soc/intel/braswell/northcluster.c@110
PS3, Line 110: 	if (fsp_reserved_memory_area){
space required before the open brace '{'


https://review.coreboot.org/#/c/29333/3/src/soc/intel/braswell/northcluster.c@111
PS3, Line 111: 		fsp_res_base_k = (RES_IN_KIB((unsigned int)fsp_reserved_memory_area));
line over 80 characters


https://review.coreboot.org/#/c/29333/3/src/soc/intel/braswell/northcluster.c@113
PS3, Line 113: 	else
that open brace { should be on the previous line


https://review.coreboot.org/#/c/29333/3/src/soc/intel/braswell/northcluster.c@113
PS3, Line 113: 	else
else should follow close brace '}'



-- 
To view, visit https://review.coreboot.org/29333
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If68bda39ba2b1f3be4ed4bc872710be7bbd4948b
Gerrit-Change-Number: 29333
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 30 Oct 2018 10:28:19 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181030/8a5bff44/attachment.html>