<p><a href="https://review.coreboot.org/29333">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29333/3/src/soc/intel/braswell/northcluster.c">File src/soc/intel/braswell/northcluster.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29333/3/src/soc/intel/braswell/northcluster.c@110">Patch Set #3, Line 110:</a> <code style="font-family:monospace,monospace">        if (fsp_reserved_memory_area){</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open brace '{'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29333/3/src/soc/intel/braswell/northcluster.c@111">Patch Set #3, Line 111:</a> <code style="font-family:monospace,monospace">              fsp_res_base_k = (RES_IN_KIB((unsigned int)fsp_reserved_memory_area));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29333/3/src/soc/intel/braswell/northcluster.c@113">Patch Set #3, Line 113:</a> <code style="font-family:monospace,monospace">       else</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">that open brace { should be on the previous line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29333/3/src/soc/intel/braswell/northcluster.c@113">Patch Set #3, Line 113:</a> <code style="font-family:monospace,monospace">        else</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">else should follow close brace '}'</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29333">change 29333</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29333"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: If68bda39ba2b1f3be4ed4bc872710be7bbd4948b </div>
<div style="display:none"> Gerrit-Change-Number: 29333 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 30 Oct 2018 10:28:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>