[coreboot-gerrit] Change in coreboot[master]: src/soc/intel/braswell/northcluster.c: Correct calculation of FSP mem...

[Frans Hendriks (Code Review)]

Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/29355


Change subject: src/soc/intel/braswell/northcluster.c: Correct calculation of FSP memory area
......................................................................

src/soc/intel/braswell/northcluster.c: Correct calculation of FSP memory area

Calculation of memory reserved by FSP is incorrect.
Use CBMEM_ID_FSP_RESERVED_MEMORY to determine the memory area

BUG=N/A
TEST=Intel CherryHill CRB

Change-Id: I0f442b188ae10ca3ef918ca53e49b0b4728d0c5e
Signed-off-by: Frans Hendriks <fhendriks at eltan.com>
---
M src/soc/intel/braswell/northcluster.c
1 file changed, 4 insertions(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/29355/1

diff --git a/src/soc/intel/braswell/northcluster.c b/src/soc/intel/braswell/northcluster.c
index 0554cd3..e341f66 100644
--- a/src/soc/intel/braswell/northcluster.c
+++ b/src/soc/intel/braswell/northcluster.c
@@ -107,11 +107,10 @@
 
 	/* Determine the base of the FSP reserved memory */
 	fsp_reserved_memory_area = cbmem_find(CBMEM_ID_FSP_RESERVED_MEMORY);
-	if (fsp_reserved_memory_area){
-		fsp_res_base_k = (RES_IN_KIB((unsigned int)fsp_reserved_memory_area));
-	}
-	else
-	{
+	if (fsp_reserved_memory_area) {
+		fsp_res_base_k =
+			RES_IN_KIB((unsigned int)fsp_reserved_memory_area);
+	} else {
 		/* If no FSP reserverd area */
 		fsp_res_base_k = tseg_base_k;
 	}

-- 
To view, visit https://review.coreboot.org/29355
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f442b188ae10ca3ef918ca53e49b0b4728d0c5e
Gerrit-Change-Number: 29355
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181030/78b2bb53/attachment.html>