<p>Frans Hendriks has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29355">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/soc/intel/braswell/northcluster.c: Correct calculation of FSP memory area<br><br>Calculation of memory reserved by FSP is incorrect.<br>Use CBMEM_ID_FSP_RESERVED_MEMORY to determine the memory area<br><br>BUG=N/A<br>TEST=Intel CherryHill CRB<br><br>Change-Id: I0f442b188ae10ca3ef918ca53e49b0b4728d0c5e<br>Signed-off-by: Frans Hendriks <fhendriks@eltan.com><br>---<br>M src/soc/intel/braswell/northcluster.c<br>1 file changed, 4 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/29355/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/braswell/northcluster.c b/src/soc/intel/braswell/northcluster.c</span><br><span>index 0554cd3..e341f66 100644</span><br><span>--- a/src/soc/intel/braswell/northcluster.c</span><br><span>+++ b/src/soc/intel/braswell/northcluster.c</span><br><span>@@ -107,11 +107,10 @@</span><br><span> </span><br><span>      /* Determine the base of the FSP reserved memory */</span><br><span>  fsp_reserved_memory_area = cbmem_find(CBMEM_ID_FSP_RESERVED_MEMORY);</span><br><span style="color: hsl(0, 100%, 40%);">-    if (fsp_reserved_memory_area){</span><br><span style="color: hsl(0, 100%, 40%);">-          fsp_res_base_k = (RES_IN_KIB((unsigned int)fsp_reserved_memory_area));</span><br><span style="color: hsl(0, 100%, 40%);">-  }</span><br><span style="color: hsl(0, 100%, 40%);">-       else</span><br><span style="color: hsl(0, 100%, 40%);">-    {</span><br><span style="color: hsl(120, 100%, 40%);">+     if (fsp_reserved_memory_area) {</span><br><span style="color: hsl(120, 100%, 40%);">+               fsp_res_base_k =</span><br><span style="color: hsl(120, 100%, 40%);">+                      RES_IN_KIB((unsigned int)fsp_reserved_memory_area);</span><br><span style="color: hsl(120, 100%, 40%);">+   } else {</span><br><span>             /* If no FSP reserverd area */</span><br><span>               fsp_res_base_k = tseg_base_k;</span><br><span>        }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29355">change 29355</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29355"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I0f442b188ae10ca3ef918ca53e49b0b4728d0c5e </div>
<div style="display:none"> Gerrit-Change-Number: 29355 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Frans Hendriks <fhendriks@eltan.com> </div>