[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variant/nocturne: add Nanya memory option

Nick Vaccaro (Code Review) gerrit at coreboot.org
Mon Oct 29 21:15:15 CET 2018


Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/29341


Change subject: mb/google/poppy/variant/nocturne: add Nanya memory option
......................................................................

mb/google/poppy/variant/nocturne: add Nanya memory option

Add option for Nanya NT6CL256T32CM-H1 part.

Add comments to indicate total memory size for convenience.

BUG=b:118624505
BRANCH=master
TEST=none

Change-Id: I82200e7b3d0a13295cb38f53ab576697ff8d302b
Signed-off-by: Nick Vaccaro <nvaccaro at google.com>
---
M src/mainboard/google/poppy/variants/nocturne/Makefile.inc
1 file changed, 15 insertions(+), 12 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/29341/1

diff --git a/src/mainboard/google/poppy/variants/nocturne/Makefile.inc b/src/mainboard/google/poppy/variants/nocturne/Makefile.inc
index c17a49c..e558cfc 100644
--- a/src/mainboard/google/poppy/variants/nocturne/Makefile.inc
+++ b/src/mainboard/google/poppy/variants/nocturne/Makefile.inc
@@ -1,17 +1,17 @@
 
 SPD_SOURCES  = empty				# 0b0000
-SPD_SOURCES  += samsung_dimm_K4E8E324EB-EGCF	# 0b0001
-SPD_SOURCES  += hynix_dimm_H9CCNNN8GTALAR-NUD	# 0b0010
-SPD_SOURCES  += samsung_dimm_K4E6E304EB-EGCF	# 0b0011
-SPD_SOURCES  += hynix_dimm_H9CCNNNBJTALAR-NUD	# 0b0100
-#SPD_SOURCES  += samsung_dimm_K4EBE304EB-EGCF	# 0b0101
-SPD_SOURCES  += samsung_dimm_K4EBE304EB-EGCG	# 0b0101
-SPD_SOURCES  += hynix_dimm_H9CCNNNCLGALAR-NUD	# 0b0110
-SPD_SOURCES  += micron_dimm_MT52L512M32D2PF-107	# 0b0111
-SPD_SOURCES  += micron_dimm_MT52L1G32D4PG-107	# 0b1000
-SPD_SOURCES  += micron_dimm_MT52L256M32D1PF-107	# 0b1001
-SPD_SOURCES  += samsung_dimm_K4E6E304EC-EGCF	# 0b1010
-SPD_SOURCES  += samsung_dimm_K4EBE304EC-EGCF	# 0b1011
+SPD_SOURCES += samsung_dimm_K4E8E324EB-EGCF	# 0b0001  4GB
+SPD_SOURCES += hynix_dimm_H9CCNNN8GTALAR-NUD	# 0b0010  4GB
+SPD_SOURCES  += samsung_dimm_K4E6E304EB-EGCF	# 0b0011  8GB
+SPD_SOURCES += hynix_dimm_H9CCNNNBJTALAR-NUD	# 0b0100  8GB
+SPD_SOURCES += samsung_dimm_K4EBE304EB-EGCG	# 0b0101 16GB
+SPD_SOURCES += hynix_dimm_H9CCNNNCLGALAR-NUD	# 0b0110 16GB
+SPD_SOURCES += micron_dimm_MT52L512M32D2PF-107	# 0b0111  8GB
+SPD_SOURCES += micron_dimm_MT52L1G32D4PG-107	# 0b1000 16GB
+SPD_SOURCES += micron_dimm_MT52L256M32D1PF-107	# 0b1001  4GB
+SPD_SOURCES += samsung_dimm_K4E6E304EC-EGCF	# 0b1010  8GB
+SPD_SOURCES += samsung_dimm_K4EBE304EC-EGCF	# 0b1011 16GB
+SPD_SOURCES += nayna_dimm_NT6CL256T32CM-H1	# 0b1100  4GB
 
 bootblock-y += gpio.c
 
@@ -20,3 +20,6 @@
 ramstage-y += gpio.c
 ramstage-y += nhlt.c
 ramstage-y += mainboard.c
+
+smm-y += ec.c
+ramstage-y += ec.c

-- 
To view, visit https://review.coreboot.org/29341
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82200e7b3d0a13295cb38f53ab576697ff8d302b
Gerrit-Change-Number: 29341
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181029/0ae63219/attachment.html>


More information about the coreboot-gerrit mailing list