<p>Nick Vaccaro has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29341">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variant/nocturne: add Nanya memory option<br><br>Add option for Nanya NT6CL256T32CM-H1 part.<br><br>Add comments to indicate total memory size for convenience.<br><br>BUG=b:118624505<br>BRANCH=master<br>TEST=none<br><br>Change-Id: I82200e7b3d0a13295cb38f53ab576697ff8d302b<br>Signed-off-by: Nick Vaccaro <nvaccaro@google.com><br>---<br>M src/mainboard/google/poppy/variants/nocturne/Makefile.inc<br>1 file changed, 15 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/29341/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/Makefile.inc b/src/mainboard/google/poppy/variants/nocturne/Makefile.inc</span><br><span>index c17a49c..e558cfc 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/Makefile.inc</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/Makefile.inc</span><br><span>@@ -1,17 +1,17 @@</span><br><span> </span><br><span> SPD_SOURCES  = empty                                # 0b0000</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES  += samsung_dimm_K4E8E324EB-EGCF    # 0b0001</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES  += hynix_dimm_H9CCNNN8GTALAR-NUD   # 0b0010</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES  += samsung_dimm_K4E6E304EB-EGCF    # 0b0011</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES  += hynix_dimm_H9CCNNNBJTALAR-NUD   # 0b0100</span><br><span style="color: hsl(0, 100%, 40%);">-#SPD_SOURCES  += samsung_dimm_K4EBE304EB-EGCF   # 0b0101</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES  += samsung_dimm_K4EBE304EB-EGCG    # 0b0101</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES  += hynix_dimm_H9CCNNNCLGALAR-NUD   # 0b0110</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES  += micron_dimm_MT52L512M32D2PF-107 # 0b0111</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES  += micron_dimm_MT52L1G32D4PG-107   # 0b1000</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES  += micron_dimm_MT52L256M32D1PF-107 # 0b1001</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES  += samsung_dimm_K4E6E304EC-EGCF    # 0b1010</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES  += samsung_dimm_K4EBE304EC-EGCF    # 0b1011</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += samsung_dimm_K4E8E324EB-EGCF   # 0b0001  4GB</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += hynix_dimm_H9CCNNN8GTALAR-NUD     # 0b0010  4GB</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES  += samsung_dimm_K4E6E304EB-EGCF     # 0b0011  8GB</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += hynix_dimm_H9CCNNNBJTALAR-NUD     # 0b0100  8GB</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += samsung_dimm_K4EBE304EB-EGCG      # 0b0101 16GB</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += hynix_dimm_H9CCNNNCLGALAR-NUD     # 0b0110 16GB</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += micron_dimm_MT52L512M32D2PF-107   # 0b0111  8GB</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += micron_dimm_MT52L1G32D4PG-107     # 0b1000 16GB</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += micron_dimm_MT52L256M32D1PF-107   # 0b1001  4GB</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += samsung_dimm_K4E6E304EC-EGCF      # 0b1010  8GB</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += samsung_dimm_K4EBE304EC-EGCF      # 0b1011 16GB</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += nayna_dimm_NT6CL256T32CM-H1       # 0b1100  4GB</span><br><span> </span><br><span> bootblock-y += gpio.c</span><br><span> </span><br><span>@@ -20,3 +20,6 @@</span><br><span> ramstage-y += gpio.c</span><br><span> ramstage-y += nhlt.c</span><br><span> ramstage-y += mainboard.c</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+smm-y += ec.c</span><br><span style="color: hsl(120, 100%, 40%);">+ramstage-y += ec.c</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29341">change 29341</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29341"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I82200e7b3d0a13295cb38f53ab576697ff8d302b </div>
<div style="display:none"> Gerrit-Change-Number: 29341 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nick Vaccaro <nvaccaro@google.com> </div>