[coreboot-gerrit] Change in coreboot[master]: src: Add missing include <stdint.h>

Nico Huber (Code Review) gerrit at coreboot.org
Mon Oct 29 13:17:15 CET 2018


Nico Huber has posted comments on this change. ( https://review.coreboot.org/29312 )

Change subject: src: Add missing include <stdint.h>
......................................................................


Patch Set 10:

(4 comments)

https://review.coreboot.org/#/c/29312/10/src/soc/intel/baytrail/include/soc/iomap.h
File src/soc/intel/baytrail/include/soc/iomap.h:

https://review.coreboot.org/#/c/29312/10/src/soc/intel/baytrail/include/soc/iomap.h@19
PS10, Line 19: #include <stdint.h>
needs __ACPI__ guard


https://review.coreboot.org/#/c/29312/10/src/soc/intel/baytrail/include/soc/iomap.h@82
PS10, Line 82: #ifndef __ACPI__
This guards the C code below from being included in ASL. The #include
needs the same guard.


https://review.coreboot.org/#/c/29312/10/src/soc/intel/braswell/include/soc/iomap.h
File src/soc/intel/braswell/include/soc/iomap.h:

https://review.coreboot.org/#/c/29312/10/src/soc/intel/braswell/include/soc/iomap.h@20
PS10, Line 20: #include <stdint.h>
same here


https://review.coreboot.org/#/c/29312/10/src/soc/intel/fsp_baytrail/include/soc/iomap.h
File src/soc/intel/fsp_baytrail/include/soc/iomap.h:

https://review.coreboot.org/#/c/29312/10/src/soc/intel/fsp_baytrail/include/soc/iomap.h@19
PS10, Line 19: #include <stdint.h>
and here



-- 
To view, visit https://review.coreboot.org/29312
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a9d71e69ed9230b92f0f330875515a5df29fc06
Gerrit-Change-Number: 29312
Gerrit-PatchSet: 10
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 29 Oct 2018 12:17:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181029/b3ecc35e/attachment.html>


More information about the coreboot-gerrit mailing list