<p><a href="https://review.coreboot.org/29312">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29312/10/src/soc/intel/baytrail/include/soc/iomap.h">File src/soc/intel/baytrail/include/soc/iomap.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29312/10/src/soc/intel/baytrail/include/soc/iomap.h@19">Patch Set #10, Line 19:</a> <code style="font-family:monospace,monospace">#include <stdint.h></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">needs __ACPI__ guard</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29312/10/src/soc/intel/baytrail/include/soc/iomap.h@82">Patch Set #10, Line 82:</a> <code style="font-family:monospace,monospace">#ifndef __ACPI__</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This guards the C code below from being included in ASL. The #include<br>needs the same guard.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29312/10/src/soc/intel/braswell/include/soc/iomap.h">File src/soc/intel/braswell/include/soc/iomap.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29312/10/src/soc/intel/braswell/include/soc/iomap.h@20">Patch Set #10, Line 20:</a> <code style="font-family:monospace,monospace">#include <stdint.h></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same here</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29312/10/src/soc/intel/fsp_baytrail/include/soc/iomap.h">File src/soc/intel/fsp_baytrail/include/soc/iomap.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29312/10/src/soc/intel/fsp_baytrail/include/soc/iomap.h@19">Patch Set #10, Line 19:</a> <code style="font-family:monospace,monospace">#include <stdint.h></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">and here</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29312">change 29312</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29312"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I6a9d71e69ed9230b92f0f330875515a5df29fc06 </div>
<div style="display:none"> Gerrit-Change-Number: 29312 </div>
<div style="display:none"> Gerrit-PatchSet: 10 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 29 Oct 2018 12:17:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>