[coreboot-gerrit] Change in coreboot[master]: {cpu, drivers, nb, sb}/amd: Replace {MSR, MTRR} addresses with macros

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29243 )

Change subject: {cpu,drivers,nb,sb}/amd: Replace {MSR,MTRR} addresses with macros
......................................................................


Patch Set 9:

(1 comment)

Also, please fix 81+ characters.

https://review.coreboot.org/#/c/29243/9/src/northbridge/amd/amdmct/mct/mctdqs_d.c
File src/northbridge/amd/amdmct/mct/mctdqs_d.c:

https://review.coreboot.org/#/c/29243/9/src/northbridge/amd/amdmct/mct/mctdqs_d.c@822
PS9, Line 822: 0xC0010017
In cpu/amd/mtrr.h replace the declarations (they are wrong):
#define IORR_FIRST 0xC0010016
#define IORR_LAST  0xC0010019
with
#define IORR0_BASE 0xC0010016
#define IORR0_MASK 0xC0010017
#define IORR1_BASE  0xC0010018
#define IORR1_MASK  0xC0010019

Then fix code where needed. This line will become:
	_WRMSR(IORR0_MASK, lo, hi);		/* IORR0 Mask */



-- 
To view, visit https://review.coreboot.org/29243
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e8de35dcdad52bb311b34bfa9b272d17ed3186b
Gerrit-Change-Number: 29243
Gerrit-PatchSet: 9
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Wed, 24 Oct 2018 15:01:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181024/7197496a/attachment.html>