<p style="white-space: pre-wrap; word-wrap: break-word;">Also, please fix 81+ characters.</p><p><a href="https://review.coreboot.org/29243">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29243/9/src/northbridge/amd/amdmct/mct/mctdqs_d.c">File src/northbridge/amd/amdmct/mct/mctdqs_d.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29243/9/src/northbridge/amd/amdmct/mct/mctdqs_d.c@822">Patch Set #9, Line 822:</a> <code style="font-family:monospace,monospace">0xC0010017</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">In cpu/amd/mtrr.h replace the declarations (they are wrong):<br>#define IORR_FIRST 0xC0010016<br>#define IORR_LAST  0xC0010019<br>with<br>#define IORR0_BASE 0xC0010016<br>#define IORR0_MASK 0xC0010017<br>#define IORR1_BASE  0xC0010018<br>#define IORR1_MASK  0xC0010019</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Then fix code where needed. This line will become:<br>      _WRMSR(IORR0_MASK, lo, hi);             /* IORR0 Mask */</pre></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29243">change 29243</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29243"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I7e8de35dcdad52bb311b34bfa9b272d17ed3186b </div>
<div style="display:none"> Gerrit-Change-Number: 29243 </div>
<div style="display:none"> Gerrit-PatchSet: 9 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 24 Oct 2018 15:01:27 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>