[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Remove unused variables of write_pci_cfg_irqs()

[Richard Spiegel (Code Review)]

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/29244


Change subject: soc/amd/common: Remove unused variables of write_pci_cfg_irqs()
......................................................................

soc/amd/common: Remove unused variables of write_pci_cfg_irqs()

Function write_pci_cfg_irqs() has "no function" variables. One variable is
set and never used, the other is only used to control a print. Remove them.

BUG=b:117950052
TEST=Build grunt.

Change-Id: Icd98db3e794e609b112f15979a3a00a2977a0fdb
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/soc/amd/common/block/pci/amd_pci_util.c
1 file changed, 0 insertions(+), 7 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/29244/1

diff --git a/src/soc/amd/common/block/pci/amd_pci_util.c b/src/soc/amd/common/block/pci/amd_pci_util.c
index 2c48ae7..ecf03d6 100644
--- a/src/soc/amd/common/block/pci/amd_pci_util.c
+++ b/src/soc/amd/common/block/pci/amd_pci_util.c
@@ -105,9 +105,7 @@
 	u16 target_pin = 0;
 	u16 int_line = 0;
 	u16 pci_intr_idx = 0; /* Index into PCI_INTR table, 0xC00/0xC01 */
-	u8  bus = 0;          /* TODO: no longer used, remove it */
 	u16 devfn = 0;
-	u8  bridged_device = 0;	/* TODO: Remove this */
 	u32 i = 0;
 	size_t limit;
 	const struct irq_idx_name *idx_name;
@@ -142,7 +140,6 @@
 		if (int_pin < 1 || int_pin > 4)
 			continue;	/* Device has invalid INT_PIN - skip  */
 
-		bus   = target_dev->bus->secondary;
 		devfn = target_dev->path.pci.devfn;
 
 		/*
@@ -218,10 +215,6 @@
 		 */
 		printk(BIOS_SPEW, "\tOrig INT_PIN\t: %d (%s)\n",
 						int_pin, pin_to_str(int_pin));
-		if (bridged_device)
-			printk(BIOS_SPEW, "\tSwizzled to\t: %d (%s)\n",
-					target_pin, pin_to_str(target_pin));
-
 		printk(BIOS_SPEW, "\tPCI_INTR idx\t: 0x%02x (%s)\n"
 				  "\tINT_LINE\t: 0x%X (IRQ %d)\n",
 				  pci_intr_idx, idx_name[i].name,

-- 
To view, visit https://review.coreboot.org/29244
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd98db3e794e609b112f15979a3a00a2977a0fdb
Gerrit-Change-Number: 29244
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181023/aa8fb137/attachment.html>