<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29244">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd/common: Remove unused variables of write_pci_cfg_irqs()<br><br>Function write_pci_cfg_irqs() has "no function" variables. One variable is<br>set and never used, the other is only used to control a print. Remove them.<br><br>BUG=b:117950052<br>TEST=Build grunt.<br><br>Change-Id: Icd98db3e794e609b112f15979a3a00a2977a0fdb<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/soc/amd/common/block/pci/amd_pci_util.c<br>1 file changed, 0 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/29244/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/common/block/pci/amd_pci_util.c b/src/soc/amd/common/block/pci/amd_pci_util.c</span><br><span>index 2c48ae7..ecf03d6 100644</span><br><span>--- a/src/soc/amd/common/block/pci/amd_pci_util.c</span><br><span>+++ b/src/soc/amd/common/block/pci/amd_pci_util.c</span><br><span>@@ -105,9 +105,7 @@</span><br><span> u16 target_pin = 0;</span><br><span> u16 int_line = 0;</span><br><span> u16 pci_intr_idx = 0; /* Index into PCI_INTR table, 0xC00/0xC01 */</span><br><span style="color: hsl(0, 100%, 40%);">- u8 bus = 0; /* TODO: no longer used, remove it */</span><br><span> u16 devfn = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- u8 bridged_device = 0; /* TODO: Remove this */</span><br><span> u32 i = 0;</span><br><span> size_t limit;</span><br><span> const struct irq_idx_name *idx_name;</span><br><span>@@ -142,7 +140,6 @@</span><br><span> if (int_pin < 1 || int_pin > 4)</span><br><span> continue; /* Device has invalid INT_PIN - skip */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- bus = target_dev->bus->secondary;</span><br><span> devfn = target_dev->path.pci.devfn;</span><br><span> </span><br><span> /*</span><br><span>@@ -218,10 +215,6 @@</span><br><span> */</span><br><span> printk(BIOS_SPEW, "\tOrig INT_PIN\t: %d (%s)\n",</span><br><span> int_pin, pin_to_str(int_pin));</span><br><span style="color: hsl(0, 100%, 40%);">- if (bridged_device)</span><br><span style="color: hsl(0, 100%, 40%);">- printk(BIOS_SPEW, "\tSwizzled to\t: %d (%s)\n",</span><br><span style="color: hsl(0, 100%, 40%);">- target_pin, pin_to_str(target_pin));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> printk(BIOS_SPEW, "\tPCI_INTR idx\t: 0x%02x (%s)\n"</span><br><span> "\tINT_LINE\t: 0x%X (IRQ %d)\n",</span><br><span> pci_intr_idx, idx_name[i].name,</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29244">change 29244</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29244"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Icd98db3e794e609b112f15979a3a00a2977a0fdb </div>
<div style="display:none"> Gerrit-Change-Number: 29244 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>