[coreboot-gerrit] Change in coreboot[master]: security/tpm: Add function to measure a region device

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/29234 )

Change subject: security/tpm: Add function to measure a region device
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/29234/2/src/security/tpm/Makefile.inc
File src/security/tpm/Makefile.inc:

https://review.coreboot.org/#/c/29234/2/src/security/tpm/Makefile.inc@51
PS2, Line 51: postcar-srcs += $(VB2_LIB)
Add bootblock if not already built in


https://review.coreboot.org/#/c/29234/2/src/security/tpm/tspi/tspi.c
File src/security/tpm/tspi/tspi.c:

https://review.coreboot.org/#/c/29234/2/src/security/tpm/tspi/tspi.c@231
PS2, Line 231: 	buf = rdev_mmap_full(rdev);
Will fuckup measurements because of memory constraints. See my previous code :)



-- 
To view, visit https://review.coreboot.org/29234
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I126cc3500fd039d63743db78002a04d201ab18aa
Gerrit-Change-Number: 29234
Gerrit-PatchSet: 3
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 23 Oct 2018 12:27:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181023/5d11a565/attachment.html>