<p><a href="https://review.coreboot.org/29234">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29234/2/src/security/tpm/Makefile.inc">File src/security/tpm/Makefile.inc:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29234/2/src/security/tpm/Makefile.inc@51">Patch Set #2, Line 51:</a> <code style="font-family:monospace,monospace">postcar-srcs += $(VB2_LIB)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add bootblock if not already built in</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29234/2/src/security/tpm/tspi/tspi.c">File src/security/tpm/tspi/tspi.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29234/2/src/security/tpm/tspi/tspi.c@231">Patch Set #2, Line 231:</a> <code style="font-family:monospace,monospace">       buf = rdev_mmap_full(rdev);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Will fuckup measurements because of memory constraints. See my previous code :)</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29234">change 29234</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29234"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I126cc3500fd039d63743db78002a04d201ab18aa </div>
<div style="display:none"> Gerrit-Change-Number: 29234 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Werner Zeh <werner.zeh@siemens.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 23 Oct 2018 12:27:06 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>