[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy: add the smi_events back

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/29191 )

Change subject: mb/google/poppy: add the smi_events back
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/29191/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/29191/1//COMMIT_MSG@12
PS1, Line 12: shutdown and will always keep in S0.
Can you please mention here that this was broken because of CL:28983?


https://review.coreboot.org/#/c/29191/1/src/mainboard/google/poppy/ec.c
File src/mainboard/google/poppy/ec.c:

https://review.coreboot.org/#/c/29191/1/src/mainboard/google/poppy/ec.c@27
PS1, Line 27: .smi_events = MAINBOARD_EC_SMI_EVENTS,
Can you please do the same thing for nocturne: https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/poppy/variants/nocturne/ec.c?id=refs/heads/master#n25



-- 
To view, visit https://review.coreboot.org/29191
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id82311a8ccd109f9c26516f59a45bdf34da98529
Gerrit-Change-Number: 29191
Gerrit-PatchSet: 1
Gerrit-Owner: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 23 Oct 2018 00:48:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181023/1312c8eb/attachment.html>