<p><a href="https://review.coreboot.org/29191">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29191/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29191/1//COMMIT_MSG@12">Patch Set #1, Line 12:</a> <code style="font-family:monospace,monospace">shutdown and will always keep in S0.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Can you please mention here that this was broken because of CL:28983?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29191/1/src/mainboard/google/poppy/ec.c">File src/mainboard/google/poppy/ec.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29191/1/src/mainboard/google/poppy/ec.c@27">Patch Set #1, Line 27:</a> <code style="font-family:monospace,monospace">.smi_events = MAINBOARD_EC_SMI_EVENTS,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Can you please do the same thing for nocturne: https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/poppy/variants/nocturne/ec.c?id=refs/heads/master#n25</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29191">change 29191</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29191"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id82311a8ccd109f9c26516f59a45bdf34da98529 </div>
<div style="display:none"> Gerrit-Change-Number: 29191 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Zhuohao Lee <zhuohao@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Zhuohao Lee <zhuohao@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 23 Oct 2018 00:48:01 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>