[coreboot-gerrit] Change in coreboot[master]: ec/google/wilco: Unmute audio on init

[Duncan Laurie (Code Review)]

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/29203


Change subject: ec/google/wilco: Unmute audio on init
......................................................................

ec/google/wilco: Unmute audio on init

The speakers start up muted, and the EC must be told by the BIOS
to unmute it.  This helps prevent popping noises on boot/resume.

Change-Id: I693f1d01e46e19362ef8fd0d5b3f4930967b5a12
Signed-off-by: Duncan Laurie <dlaurie at google.com>
---
M src/ec/google/wilco/chip.c
M src/ec/google/wilco/commands.h
2 files changed, 10 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/29203/1

diff --git a/src/ec/google/wilco/chip.c b/src/ec/google/wilco/chip.c
index 929d1cc..0cd0048 100644
--- a/src/ec/google/wilco/chip.c
+++ b/src/ec/google/wilco/chip.c
@@ -63,6 +63,9 @@
 
 	/* Direct power button to the host for processing */
 	wilco_ec_send(KB_POWER_BUTTON_TO_HOST, 1);
+
+	/* Unmute speakers */
+	wilco_ec_send(KB_HW_MUTE_CONTROL, AUDIO_UNMUTE_125MS);
 }
 
 static void wilco_ec_resource(struct device *dev, int index,
diff --git a/src/ec/google/wilco/commands.h b/src/ec/google/wilco/commands.h
index 7a9bc05..4a19030 100644
--- a/src/ec/google/wilco/commands.h
+++ b/src/ec/google/wilco/commands.h
@@ -36,6 +36,8 @@
 	KB_ACPI = 0x3a,
 	/* Manage the EC power button passthru to the host */
 	KB_POWER_BUTTON_TO_HOST = 0x3e,
+	/* Manage the EC control of speaker mute */
+	KB_HW_MUTE_CONTROL = 0x60,
 	/* Inform the EC that the host is about to enter S3 */
 	KB_SLP_EN = 0x64,
 	/* Inform the EC about BIOS boot progress */
@@ -54,6 +56,11 @@
 	BIOS_PROGRESS_POST_COMPLETE = 0x04,
 };
 
+enum ec_audio_mute {
+	AUDIO_MUTE = 0,		/* Mute speakers immediately */
+	AUDIO_UNMUTE_125MS,	/* Unmute in 125ms */
+};
+
 /*
  * EC Information
  */

-- 
To view, visit https://review.coreboot.org/29203
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I693f1d01e46e19362ef8fd0d5b3f4930967b5a12
Gerrit-Change-Number: 29203
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181020/ec33c016/attachment.html>