<p>Duncan Laurie has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29203">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ec/google/wilco: Unmute audio on init<br><br>The speakers start up muted, and the EC must be told by the BIOS<br>to unmute it.  This helps prevent popping noises on boot/resume.<br><br>Change-Id: I693f1d01e46e19362ef8fd0d5b3f4930967b5a12<br>Signed-off-by: Duncan Laurie <dlaurie@google.com><br>---<br>M src/ec/google/wilco/chip.c<br>M src/ec/google/wilco/commands.h<br>2 files changed, 10 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/29203/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ec/google/wilco/chip.c b/src/ec/google/wilco/chip.c</span><br><span>index 929d1cc..0cd0048 100644</span><br><span>--- a/src/ec/google/wilco/chip.c</span><br><span>+++ b/src/ec/google/wilco/chip.c</span><br><span>@@ -63,6 +63,9 @@</span><br><span> </span><br><span>      /* Direct power button to the host for processing */</span><br><span>         wilco_ec_send(KB_POWER_BUTTON_TO_HOST, 1);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  /* Unmute speakers */</span><br><span style="color: hsl(120, 100%, 40%);">+ wilco_ec_send(KB_HW_MUTE_CONTROL, AUDIO_UNMUTE_125MS);</span><br><span> }</span><br><span> </span><br><span> static void wilco_ec_resource(struct device *dev, int index,</span><br><span>diff --git a/src/ec/google/wilco/commands.h b/src/ec/google/wilco/commands.h</span><br><span>index 7a9bc05..4a19030 100644</span><br><span>--- a/src/ec/google/wilco/commands.h</span><br><span>+++ b/src/ec/google/wilco/commands.h</span><br><span>@@ -36,6 +36,8 @@</span><br><span>     KB_ACPI = 0x3a,</span><br><span>      /* Manage the EC power button passthru to the host */</span><br><span>        KB_POWER_BUTTON_TO_HOST = 0x3e,</span><br><span style="color: hsl(120, 100%, 40%);">+       /* Manage the EC control of speaker mute */</span><br><span style="color: hsl(120, 100%, 40%);">+   KB_HW_MUTE_CONTROL = 0x60,</span><br><span>   /* Inform the EC that the host is about to enter S3 */</span><br><span>       KB_SLP_EN = 0x64,</span><br><span>    /* Inform the EC about BIOS boot progress */</span><br><span>@@ -54,6 +56,11 @@</span><br><span>    BIOS_PROGRESS_POST_COMPLETE = 0x04,</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+enum ec_audio_mute {</span><br><span style="color: hsl(120, 100%, 40%);">+   AUDIO_MUTE = 0,         /* Mute speakers immediately */</span><br><span style="color: hsl(120, 100%, 40%);">+       AUDIO_UNMUTE_125MS,     /* Unmute in 125ms */</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /*</span><br><span>  * EC Information</span><br><span>  */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29203">change 29203</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29203"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I693f1d01e46e19362ef8fd0d5b3f4930967b5a12 </div>
<div style="display:none"> Gerrit-Change-Number: 29203 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>