[coreboot-gerrit] Change in coreboot[master]: security/tpm: Add generalized ACPI table generation
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Fri Oct 19 14:41:02 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29194 )
Change subject: security/tpm: Add generalized ACPI table generation
......................................................................
Patch Set 2:
(47 comments)
https://review.coreboot.org/#/c/29194/2/src/drivers/i2c/tpm/acpi.c
File src/drivers/i2c/tpm/acpi.c:
https://review.coreboot.org/#/c/29194/2/src/drivers/i2c/tpm/acpi.c@30
PS2, Line 30: .acpi_name = &tpm_acpi_name,
please, no space before tabs
https://review.coreboot.org/#/c/29194/2/src/drivers/i2c/tpm/acpi.c@40
PS2, Line 40: if (config && config->desc) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c
File src/security/tpm/acpi/acpi.c:
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@78
PS2, Line 78: if (config->disable_gpio_export_in_crs || ((config->reset_gpio.pin_count == 0) && (config->enable_gpio.pin_count == 0)))
line over 80 characters
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@146
PS2, Line 146: * Set preferred user language: deprecated and must return 3 aka
code indent should use tabs where possible
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@146
PS2, Line 146: * Set preferred user language: deprecated and must return 3 aka
please, no space before tabs
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@147
PS2, Line 147: * "not implemented".
code indent should use tabs where possible
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@147
PS2, Line 147: * "not implemented".
please, no space before tabs
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@148
PS2, Line 148: */
code indent should use tabs where possible
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@148
PS2, Line 148: */
please, no space before tabs
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@219
PS2, Line 219: printk(BIOS_ERR, "%s: ERROR: HID required.\n", dev_path(dev));
line over 80 characters
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@234
PS2, Line 234: printk(BIOS_ERR, "%s: ERROR: HID required.\n", dev_path(dev));
line over 80 characters
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@286
PS2, Line 286: reset_gpio_index = spi_acpi_write_gpio(&config->reset_gpio,
line over 80 characters
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@288
PS2, Line 288: enable_gpio_index = spi_acpi_write_gpio(&config->enable_gpio,
line over 80 characters
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@311
PS2, Line 311: acpigen_write_mem32fixed(1, CONFIG_TPM_TIS_BASE_ADDRESS, TPM_TIS_BASE_LENGTH);
line over 80 characters
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@312
PS2, Line 312: acpigen_write_io16(dev->path.pnp.port, dev->path.pnp.port, 1, 2, 1);
line over 80 characters
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@316
PS2, Line 316: * PIRQ: Update interrupt vector with configured PIRQ
code indent should use tabs where possible
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@316
PS2, Line 316: * PIRQ: Update interrupt vector with configured PIRQ
please, no space before tabs
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@317
PS2, Line 317: * Active-Low Level-Triggered Shared
code indent should use tabs where possible
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@317
PS2, Line 317: * Active-Low Level-Triggered Shared
please, no space before tabs
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@318
PS2, Line 318: */
code indent should use tabs where possible
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@318
PS2, Line 318: */
please, no space before tabs
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@319
PS2, Line 319: struct acpi_irq tpm_irq_a = ACPI_IRQ_LEVEL_LOW(CONFIG_TPM_PIRQ);
line over 80 characters
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@342
PS2, Line 342: /* Power ressources */
'ressources' may be misspelled - perhaps 'resources'?
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@353
PS2, Line 353: if (config->compat_string || irq_gpio_index >= 0 || reset_gpio_index >= 0 || enable_gpio_index >= 0) {
line over 80 characters
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@359
PS2, Line 359: acpi_dp_add_gpio(dsd, "irq-gpios", acpi_device_path(dev),
line over 80 characters
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@363
PS2, Line 363: acpi_dp_add_gpio(dsd, "reset-gpios", acpi_device_path(dev),
line over 80 characters
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@367
PS2, Line 367: acpi_dp_add_gpio(dsd, "enable-gpios", acpi_device_path(dev),
line over 80 characters
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@393
PS2, Line 393: * _DSM method
code indent should use tabs where possible
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@393
PS2, Line 393: * _DSM method
please, no space before tabs
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@394
PS2, Line 394: */
code indent should use tabs where possible
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@394
PS2, Line 394: */
please, no space before tabs
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@397
PS2, Line 397: * This is used to submit commands like "Clear TPM" to
code indent should use tabs where possible
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@397
PS2, Line 397: * This is used to submit commands like "Clear TPM" to
please, no space before tabs
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@398
PS2, Line 398: * be run at next reboot provided that user confirms
code indent should use tabs where possible
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@398
PS2, Line 398: * be run at next reboot provided that user confirms
please, no space before tabs
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@399
PS2, Line 399: * them. Spec allows user to cancel all commands and/or
code indent should use tabs where possible
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@399
PS2, Line 399: * them. Spec allows user to cancel all commands and/or
please, no space before tabs
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@400
PS2, Line 400: * configure BIOS to reject commands. So we pretend that
code indent should use tabs where possible
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@400
PS2, Line 400: * configure BIOS to reject commands. So we pretend that
please, no space before tabs
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@401
PS2, Line 401: * user did just this: cancelled everything. If user
code indent should use tabs where possible
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@401
PS2, Line 401: * user did just this: cancelled everything. If user
please, no space before tabs
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@402
PS2, Line 402: * really wants to clear TPM the only option now is to
code indent should use tabs where possible
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@402
PS2, Line 402: * really wants to clear TPM the only option now is to
please, no space before tabs
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@403
PS2, Line 403: * do it manually in payload.
code indent should use tabs where possible
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@403
PS2, Line 403: * do it manually in payload.
please, no space before tabs
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@404
PS2, Line 404: */
code indent should use tabs where possible
https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@404
PS2, Line 404: */
please, no space before tabs
--
To view, visit https://review.coreboot.org/29194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2afdf4872566353284ab7734205a3bea738a6e0e
Gerrit-Change-Number: 29194
Gerrit-PatchSet: 2
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 19 Oct 2018 12:41:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181019/dbb03e6c/attachment.html>
More information about the coreboot-gerrit
mailing list