<p><a href="https://review.coreboot.org/29194">View Change</a></p><p>47 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29194/2/src/drivers/i2c/tpm/acpi.c">File src/drivers/i2c/tpm/acpi.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/drivers/i2c/tpm/acpi.c@30">Patch Set #2, Line 30:</a> <code style="font-family:monospace,monospace"> .acpi_name = &tpm_acpi_name,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/drivers/i2c/tpm/acpi.c@40">Patch Set #2, Line 40:</a> <code style="font-family:monospace,monospace"> if (config && config->desc) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c">File src/security/tpm/acpi/acpi.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@78">Patch Set #2, Line 78:</a> <code style="font-family:monospace,monospace"> if (config->disable_gpio_export_in_crs || ((config->reset_gpio.pin_count == 0) && (config->enable_gpio.pin_count == 0)))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@146">Patch Set #2, Line 146:</a> <code style="font-family:monospace,monospace"> * Set preferred user language: deprecated and must return 3 aka</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@146">Patch Set #2, Line 146:</a> <code style="font-family:monospace,monospace"> * Set preferred user language: deprecated and must return 3 aka</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@147">Patch Set #2, Line 147:</a> <code style="font-family:monospace,monospace"> * "not implemented".</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@147">Patch Set #2, Line 147:</a> <code style="font-family:monospace,monospace"> * "not implemented".</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@148">Patch Set #2, Line 148:</a> <code style="font-family:monospace,monospace"> */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@148">Patch Set #2, Line 148:</a> <code style="font-family:monospace,monospace"> */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@219">Patch Set #2, Line 219:</a> <code style="font-family:monospace,monospace"> printk(BIOS_ERR, "%s: ERROR: HID required.\n", dev_path(dev));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@234">Patch Set #2, Line 234:</a> <code style="font-family:monospace,monospace"> printk(BIOS_ERR, "%s: ERROR: HID required.\n", dev_path(dev));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@286">Patch Set #2, Line 286:</a> <code style="font-family:monospace,monospace"> reset_gpio_index = spi_acpi_write_gpio(&config->reset_gpio,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@288">Patch Set #2, Line 288:</a> <code style="font-family:monospace,monospace"> enable_gpio_index = spi_acpi_write_gpio(&config->enable_gpio,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@311">Patch Set #2, Line 311:</a> <code style="font-family:monospace,monospace"> acpigen_write_mem32fixed(1, CONFIG_TPM_TIS_BASE_ADDRESS, TPM_TIS_BASE_LENGTH);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@312">Patch Set #2, Line 312:</a> <code style="font-family:monospace,monospace"> acpigen_write_io16(dev->path.pnp.port, dev->path.pnp.port, 1, 2, 1);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@316">Patch Set #2, Line 316:</a> <code style="font-family:monospace,monospace"> * PIRQ: Update interrupt vector with configured PIRQ</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@316">Patch Set #2, Line 316:</a> <code style="font-family:monospace,monospace"> * PIRQ: Update interrupt vector with configured PIRQ</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@317">Patch Set #2, Line 317:</a> <code style="font-family:monospace,monospace"> * Active-Low Level-Triggered Shared</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@317">Patch Set #2, Line 317:</a> <code style="font-family:monospace,monospace"> * Active-Low Level-Triggered Shared</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@318">Patch Set #2, Line 318:</a> <code style="font-family:monospace,monospace"> */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@318">Patch Set #2, Line 318:</a> <code style="font-family:monospace,monospace"> */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@319">Patch Set #2, Line 319:</a> <code style="font-family:monospace,monospace"> struct acpi_irq tpm_irq_a = ACPI_IRQ_LEVEL_LOW(CONFIG_TPM_PIRQ);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@342">Patch Set #2, Line 342:</a> <code style="font-family:monospace,monospace"> /* Power ressources */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">'ressources' may be misspelled - perhaps 'resources'?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@353">Patch Set #2, Line 353:</a> <code style="font-family:monospace,monospace"> if (config->compat_string || irq_gpio_index >= 0 || reset_gpio_index >= 0 || enable_gpio_index >= 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@359">Patch Set #2, Line 359:</a> <code style="font-family:monospace,monospace"> acpi_dp_add_gpio(dsd, "irq-gpios", acpi_device_path(dev),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@363">Patch Set #2, Line 363:</a> <code style="font-family:monospace,monospace"> acpi_dp_add_gpio(dsd, "reset-gpios", acpi_device_path(dev),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@367">Patch Set #2, Line 367:</a> <code style="font-family:monospace,monospace"> acpi_dp_add_gpio(dsd, "enable-gpios", acpi_device_path(dev),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@393">Patch Set #2, Line 393:</a> <code style="font-family:monospace,monospace"> * _DSM method</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@393">Patch Set #2, Line 393:</a> <code style="font-family:monospace,monospace"> * _DSM method</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@394">Patch Set #2, Line 394:</a> <code style="font-family:monospace,monospace"> */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@394">Patch Set #2, Line 394:</a> <code style="font-family:monospace,monospace"> */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@397">Patch Set #2, Line 397:</a> <code style="font-family:monospace,monospace"> * This is used to submit commands like "Clear TPM" to</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@397">Patch Set #2, Line 397:</a> <code style="font-family:monospace,monospace"> * This is used to submit commands like "Clear TPM" to</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@398">Patch Set #2, Line 398:</a> <code style="font-family:monospace,monospace"> * be run at next reboot provided that user confirms</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@398">Patch Set #2, Line 398:</a> <code style="font-family:monospace,monospace"> * be run at next reboot provided that user confirms</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@399">Patch Set #2, Line 399:</a> <code style="font-family:monospace,monospace"> * them. Spec allows user to cancel all commands and/or</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@399">Patch Set #2, Line 399:</a> <code style="font-family:monospace,monospace"> * them. Spec allows user to cancel all commands and/or</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@400">Patch Set #2, Line 400:</a> <code style="font-family:monospace,monospace"> * configure BIOS to reject commands. So we pretend that</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@400">Patch Set #2, Line 400:</a> <code style="font-family:monospace,monospace"> * configure BIOS to reject commands. So we pretend that</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@401">Patch Set #2, Line 401:</a> <code style="font-family:monospace,monospace"> * user did just this: cancelled everything. If user</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@401">Patch Set #2, Line 401:</a> <code style="font-family:monospace,monospace"> * user did just this: cancelled everything. If user</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@402">Patch Set #2, Line 402:</a> <code style="font-family:monospace,monospace"> * really wants to clear TPM the only option now is to</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@402">Patch Set #2, Line 402:</a> <code style="font-family:monospace,monospace"> * really wants to clear TPM the only option now is to</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@403">Patch Set #2, Line 403:</a> <code style="font-family:monospace,monospace"> * do it manually in payload.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@403">Patch Set #2, Line 403:</a> <code style="font-family:monospace,monospace"> * do it manually in payload.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@404">Patch Set #2, Line 404:</a> <code style="font-family:monospace,monospace"> */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29194/2/src/security/tpm/acpi/acpi.c@404">Patch Set #2, Line 404:</a> <code style="font-family:monospace,monospace"> */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29194">change 29194</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29194"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I2afdf4872566353284ab7734205a3bea738a6e0e </div>
<div style="display:none"> Gerrit-Change-Number: 29194 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 19 Oct 2018 12:41:02 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>