[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy: add the smi_events back
Zhuohao Lee (Code Review)
gerrit at coreboot.org
Fri Oct 19 11:18:08 CEST 2018
Zhuohao Lee has uploaded this change for review. ( https://review.coreboot.org/29191
Change subject: mb/google/poppy: add the smi_events back
......................................................................
mb/google/poppy: add the smi_events back
Before entering the OS, the AP relies on the smi handler to shutdown
the system when the lid closes. Without the smi_events setting, the
AP will not receive the smi handler. As a result, the AP won't
shutdown and will always keep in S0.
BRANCH=master
BUG=b:115572596
TEST=test_that -b ${BOARD} ${IP} firmware_ECLidShutdown
Change-Id: Id82311a8ccd109f9c26516f59a45bdf34da98529
Signed-off-by: Zhuohao Lee <zhuohao at chromium.org>
---
M src/mainboard/google/poppy/ec.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/29191/1
diff --git a/src/mainboard/google/poppy/ec.c b/src/mainboard/google/poppy/ec.c
index 71327be..a93bf19 100644
--- a/src/mainboard/google/poppy/ec.c
+++ b/src/mainboard/google/poppy/ec.c
@@ -24,6 +24,7 @@
static const struct google_chromeec_event_info info = {
.log_events = MAINBOARD_EC_LOG_EVENTS,
.sci_events = MAINBOARD_EC_SCI_EVENTS,
+ .smi_events = MAINBOARD_EC_SMI_EVENTS,
.s3_wake_events = MAINBOARD_EC_S3_WAKE_EVENTS,
.s5_wake_events = MAINBOARD_EC_S5_WAKE_EVENTS,
.s0ix_wake_events = MAINBOARD_EC_S0IX_WAKE_EVENTS,
--
To view, visit https://review.coreboot.org/29191
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id82311a8ccd109f9c26516f59a45bdf34da98529
Gerrit-Change-Number: 29191
Gerrit-PatchSet: 1
Gerrit-Owner: Zhuohao Lee <zhuohao at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181019/30c87e6f/attachment.html>
More information about the coreboot-gerrit
mailing list