[coreboot-gerrit] Change in coreboot[master]: google/kukui: Support recovery mode

Tristan Hsieh (Code Review) gerrit at coreboot.org
Fri Oct 19 06:40:57 CEST 2018


Tristan Hsieh has uploaded this change for review. ( https://review.coreboot.org/29190


Change subject: google/kukui: Support recovery mode
......................................................................

google/kukui: Support recovery mode

Get recovery mode switch from EC and pass it to payload.

BUG=b:80501386
BRANCH=none
Test: Boots correctly on Kukui.

Change-Id: Ib92afca885e5a97ec4646f55f2279ef56a61af5a
Signed-off-by: Tristan Shieh <tristan.shieh at mediatek.com>
---
M src/mainboard/google/kukui/Kconfig
M src/mainboard/google/kukui/chromeos.c
2 files changed, 4 insertions(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/29190/1

diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig
index 9e01464..7032d67 100644
--- a/src/mainboard/google/kukui/Kconfig
+++ b/src/mainboard/google/kukui/Kconfig
@@ -1,6 +1,7 @@
 if BOARD_GOOGLE_KUKUI
 
 config VBOOT
+	select EC_GOOGLE_CHROMEEC_SWITCHES
 	select VBOOT_MOCK_SECDATA
 
 config BOARD_SPECIFIC_OPTIONS
@@ -12,6 +13,8 @@
 	select SPI_FLASH
 	select FATAL_ASSERTS
 	select SPI_FLASH_INCLUDE_ALL_DRIVERS
+	select EC_GOOGLE_CHROMEEC
+	select EC_GOOGLE_CHROMEEC_SPI
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/google/kukui/chromeos.c b/src/mainboard/google/kukui/chromeos.c
index bb14b1c..ace99bc 100644
--- a/src/mainboard/google/kukui/chromeos.c
+++ b/src/mainboard/google/kukui/chromeos.c
@@ -28,17 +28,13 @@
 void fill_lb_gpios(struct lb_gpios *gpios)
 {
 	struct lb_gpio chromeos_gpios[] = {
+		{-1, ACTIVE_HIGH, get_recovery_mode_switch(), "recovery"},
 		{EC_IN_RW.id, ACTIVE_HIGH, -1, "EC in RW"},
 		{EC_IRQ.id, ACTIVE_LOW, -1, "EC interrupt"},
 	};
 	lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios));
 }
 
-int get_recovery_mode_switch(void)
-{
-	return 0;
-}
-
 int get_write_protect_state(void)
 {
 	return 0;

-- 
To view, visit https://review.coreboot.org/29190
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib92afca885e5a97ec4646f55f2279ef56a61af5a
Gerrit-Change-Number: 29190
Gerrit-PatchSet: 1
Gerrit-Owner: Tristan Hsieh <tristan.shieh at mediatek.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181019/8710c706/attachment.html>


More information about the coreboot-gerrit mailing list