[coreboot-gerrit] Change in coreboot[master]: soc/intel/icelake: Do initial SoC commit

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Fri Oct 19 11:17:13 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29162 )

Change subject: soc/intel/icelake: Do initial SoC commit
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/29162/5/src/soc/intel/icelake/include/soc/romstage.h
File src/soc/intel/icelake/include/soc/romstage.h:

https://review.coreboot.org/#/c/29162/5/src/soc/intel/icelake/include/soc/romstage.h@22
PS5, Line 22: void mainboard_memory_init_params(FSPM_UPD *mupd);
need consistent spacing around '*' (ctx:WxV)



-- 
To view, visit https://review.coreboot.org/29162
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I756fa7275c4190aebc0695f14484498aaf5662a5
Gerrit-Change-Number: 29162
Gerrit-PatchSet: 5
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi at google.com>
Gerrit-Comment-Date: Fri, 19 Oct 2018 09:17:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181019/3edf0dc3/attachment.html>


More information about the coreboot-gerrit mailing list