[coreboot-gerrit] Change in coreboot[master]: soc/intel/icelake: Do initial SoC commit
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Fri Oct 19 06:57:01 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29162 )
Change subject: soc/intel/icelake: Do initial SoC commit
......................................................................
Patch Set 4:
(9 comments)
https://review.coreboot.org/#/c/29162/4/src/soc/intel/icelake/acpi.c
File src/soc/intel/icelake/acpi.c:
https://review.coreboot.org/#/c/29162/4/src/soc/intel/icelake/acpi.c@208
PS4, Line 208: if (IS_ENABLED(CONFIG_CONSOLE_CBMEM))
suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/#/c/29162/4/src/soc/intel/icelake/bootblock/pch.c
File src/soc/intel/icelake/bootblock/pch.c:
https://review.coreboot.org/#/c/29162/4/src/soc/intel/icelake/bootblock/pch.c@53
PS4, Line 53: #define TCOEN (1 << 1) /* Enable TCO I/O range decode. */
line over 80 characters
https://review.coreboot.org/#/c/29162/4/src/soc/intel/icelake/bootblock/pch.c@124
PS4, Line 124: if (pmc_reg_value != 0xFFFFFFFF)
that open brace { should be on the previous line
https://review.coreboot.org/#/c/29162/4/src/soc/intel/icelake/bootblock/report_platform.c
File src/soc/intel/icelake/bootblock/report_platform.c:
https://review.coreboot.org/#/c/29162/4/src/soc/intel/icelake/bootblock/report_platform.c@104
PS4, Line 104: int j=0;
spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/#/c/29162/4/src/soc/intel/icelake/bootblock/report_platform.c@113
PS4, Line 113: p[12]=0;
spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/#/c/29162/4/src/soc/intel/icelake/cbmem.c
File src/soc/intel/icelake/cbmem.c:
https://review.coreboot.org/#/c/29162/4/src/soc/intel/icelake/cbmem.c@20
PS4, Line 20: /* not implemented yet */
code indent should use tabs where possible
https://review.coreboot.org/#/c/29162/4/src/soc/intel/icelake/include/soc/romstage.h
File src/soc/intel/icelake/include/soc/romstage.h:
https://review.coreboot.org/#/c/29162/4/src/soc/intel/icelake/include/soc/romstage.h@22
PS4, Line 22: void mainboard_memory_init_params(FSPM_UPD *mupd);
need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/#/c/29162/4/src/soc/intel/icelake/sd.c
File src/soc/intel/icelake/sd.c:
https://review.coreboot.org/#/c/29162/4/src/soc/intel/icelake/sd.c@19
PS4, Line 19: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, struct device *dev)
"foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/29162/4/src/soc/intel/icelake/smihandler.c
File src/soc/intel/icelake/smihandler.c:
https://review.coreboot.org/#/c/29162/4/src/soc/intel/icelake/smihandler.c@83
PS4, Line 83: return ;
space prohibited before semicolon
--
To view, visit https://review.coreboot.org/29162
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I756fa7275c4190aebc0695f14484498aaf5662a5
Gerrit-Change-Number: 29162
Gerrit-PatchSet: 4
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi at google.com>
Gerrit-Comment-Date: Fri, 19 Oct 2018 04:57:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181019/24e36f39/attachment.html>
More information about the coreboot-gerrit
mailing list