[coreboot-gerrit] Change in coreboot[master]: This patch fixes Klockwork issues due to the possibility of a NULL po...

[Jonathan Neuschäfer (Code Review)]

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/29045 )

Change subject: This patch fixes Klockwork issues due to the possibility of a NULL pointer being dereferenced
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/29045/2//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/29045/2//COMMIT_MSG@7
PS2, Line 7: This patch fixes Klockwork issues due to the possibility of a NULL pointer being dereferenced
Please use a slightly shorter commit title, like
"Fix potential NULL pointer dereferences reported by Klockwork"


https://review.coreboot.org/#/c/29045/2/src/arch/x86/acpigen.c
File src/arch/x86/acpigen.c:

https://review.coreboot.org/#/c/29045/2/src/arch/x86/acpigen.c@289
PS2, Line 289: 	/* If we have an incoming NULL namepath Then we need to put a null
Please use a comma (,) before "then", rather than spelling "then" in uppercase.



-- 
To view, visit https://review.coreboot.org/29045
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife366fcb9f8932b39f4a227082c1724e25aa83d1
Gerrit-Change-Number: 29045
Gerrit-PatchSet: 2
Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso at intel.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 18 Oct 2018 17:33:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181018/06c3e9c6/attachment.html>