<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://review.coreboot.org/29045">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29045/2//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29045/2//COMMIT_MSG@7">Patch Set #2, Line 7:</a> <code style="font-family:monospace,monospace">This patch fixes Klockwork issues due to the possibility of a NULL pointer being dereferenced</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Please use a slightly shorter commit title, like<br>"Fix potential NULL pointer dereferences reported by Klockwork"</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29045/2/src/arch/x86/acpigen.c">File src/arch/x86/acpigen.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29045/2/src/arch/x86/acpigen.c@289">Patch Set #2, Line 289:</a> <code style="font-family:monospace,monospace">        /* If we have an incoming NULL namepath Then we need to put a null</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Please use a comma (,) before "then", rather than spelling "then" in uppercase.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29045">change 29045</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29045"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ife366fcb9f8932b39f4a227082c1724e25aa83d1 </div>
<div style="display:none"> Gerrit-Change-Number: 29045 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer@gmx.net> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 18 Oct 2018 17:33:11 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>