[coreboot-gerrit] Change in coreboot[master]: Macro for adding raw integer into CBFS.

Zheng Bao (Code Review) gerrit at coreboot.org
Wed Oct 17 06:28:30 CEST 2018


Zheng Bao has posted comments on this change. ( https://review.coreboot.org/29158 )

Change subject: Macro for adding raw integer into CBFS.
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> How is this different from the cbfstool add-int command?
> 
>  add-int [-r image,regions] -i INTEGER -n NAME [-b base]     Add a raw 64-bit integer value

We could not add an integer other than adding a line into root Makefile.inc.
Like:
	$(CBFSTOOL) $@.tmp add-int -i $(CONFIG_SEABIOS_PS2_TIMEOUT) -n etc/ps2-keyboard-spinup
With this macro, we can add by modifying mainboard Makefile.


-- 
To view, visit https://review.coreboot.org/29158
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id82950031063e1b0ceee80fff0553ea93dfa331a
Gerrit-Change-Number: 29158
Gerrit-PatchSet: 1
Gerrit-Owner: Zheng Bao <fishbaozi at gmail.com>
Gerrit-Reviewer: Zheng Bao <fishbaozi at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Wed, 17 Oct 2018 04:28:30 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181017/c8cd8e47/attachment.html>


More information about the coreboot-gerrit mailing list