[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge/southbridge.c: Fix comparison order

[Richard Spiegel (Code Review)]

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/29153


Change subject: soc/amd/stoneyridge/southbridge.c: Fix comparison order
......................................................................

soc/amd/stoneyridge/southbridge.c: Fix comparison order

Comparison should be variable first, constant last. Southbridge.c has 6
instances where the opposite happens. Fix them.

BUG=b:117656929
TEST=Build grunt.

Change-Id: I94f17b81f845fa94599f93c0be1144ffcb8e4165
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/soc/amd/stoneyridge/southbridge.c
1 file changed, 6 insertions(+), 6 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/29153/1

diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c
index b7ddd57..33330a8 100644
--- a/src/soc/amd/stoneyridge/southbridge.c
+++ b/src/soc/amd/stoneyridge/southbridge.c
@@ -53,22 +53,22 @@
 
 static int is_sata_config(void)
 {
-	return !((CONFIG_STONEYRIDGE_SATA_MODE == SataNativeIde)
-			|| (CONFIG_STONEYRIDGE_SATA_MODE == SataLegacyIde));
+	return !((SataNativeIde == CONFIG_STONEYRIDGE_SATA_MODE)
+			|| (SataLegacyIde == CONFIG_STONEYRIDGE_SATA_MODE));
 }
 
 static inline int sb_sata_enable(void)
 {
 	/* True if IDE or AHCI. */
-	return (CONFIG_STONEYRIDGE_SATA_MODE == SataNativeIde) ||
-		(CONFIG_STONEYRIDGE_SATA_MODE == SataAhci);
+	return (SataNativeIde == CONFIG_STONEYRIDGE_SATA_MODE) ||
+		(SataAhci == CONFIG_STONEYRIDGE_SATA_MODE);
 }
 
 static inline int sb_ide_enable(void)
 {
 	/* True if IDE or LEGACY IDE. */
-	return (CONFIG_STONEYRIDGE_SATA_MODE == SataNativeIde) ||
-		(CONFIG_STONEYRIDGE_SATA_MODE == SataLegacyIde);
+	return (SataNativeIde == CONFIG_STONEYRIDGE_SATA_MODE) ||
+		(SataLegacyIde == CONFIG_STONEYRIDGE_SATA_MODE);
 }
 
 void SetFchResetParams(FCH_RESET_INTERFACE *params)

-- 
To view, visit https://review.coreboot.org/29153
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94f17b81f845fa94599f93c0be1144ffcb8e4165
Gerrit-Change-Number: 29153
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181016/8ac157d4/attachment-0001.html>