<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29153">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd/stoneyridge/southbridge.c: Fix comparison order<br><br>Comparison should be variable first, constant last. Southbridge.c has 6<br>instances where the opposite happens. Fix them.<br><br>BUG=b:117656929<br>TEST=Build grunt.<br><br>Change-Id: I94f17b81f845fa94599f93c0be1144ffcb8e4165<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/soc/amd/stoneyridge/southbridge.c<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/29153/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c</span><br><span>index b7ddd57..33330a8 100644</span><br><span>--- a/src/soc/amd/stoneyridge/southbridge.c</span><br><span>+++ b/src/soc/amd/stoneyridge/southbridge.c</span><br><span>@@ -53,22 +53,22 @@</span><br><span> </span><br><span> static int is_sata_config(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   return !((CONFIG_STONEYRIDGE_SATA_MODE == SataNativeIde)</span><br><span style="color: hsl(0, 100%, 40%);">-                        || (CONFIG_STONEYRIDGE_SATA_MODE == SataLegacyIde));</span><br><span style="color: hsl(120, 100%, 40%);">+  return !((SataNativeIde == CONFIG_STONEYRIDGE_SATA_MODE)</span><br><span style="color: hsl(120, 100%, 40%);">+                      || (SataLegacyIde == CONFIG_STONEYRIDGE_SATA_MODE));</span><br><span> }</span><br><span> </span><br><span> static inline int sb_sata_enable(void)</span><br><span> {</span><br><span>         /* True if IDE or AHCI. */</span><br><span style="color: hsl(0, 100%, 40%);">-      return (CONFIG_STONEYRIDGE_SATA_MODE == SataNativeIde) ||</span><br><span style="color: hsl(0, 100%, 40%);">-               (CONFIG_STONEYRIDGE_SATA_MODE == SataAhci);</span><br><span style="color: hsl(120, 100%, 40%);">+   return (SataNativeIde == CONFIG_STONEYRIDGE_SATA_MODE) ||</span><br><span style="color: hsl(120, 100%, 40%);">+             (SataAhci == CONFIG_STONEYRIDGE_SATA_MODE);</span><br><span> }</span><br><span> </span><br><span> static inline int sb_ide_enable(void)</span><br><span> {</span><br><span>   /* True if IDE or LEGACY IDE. */</span><br><span style="color: hsl(0, 100%, 40%);">-        return (CONFIG_STONEYRIDGE_SATA_MODE == SataNativeIde) ||</span><br><span style="color: hsl(0, 100%, 40%);">-               (CONFIG_STONEYRIDGE_SATA_MODE == SataLegacyIde);</span><br><span style="color: hsl(120, 100%, 40%);">+      return (SataNativeIde == CONFIG_STONEYRIDGE_SATA_MODE) ||</span><br><span style="color: hsl(120, 100%, 40%);">+             (SataLegacyIde == CONFIG_STONEYRIDGE_SATA_MODE);</span><br><span> }</span><br><span> </span><br><span> void SetFchResetParams(FCH_RESET_INTERFACE *params)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29153">change 29153</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29153"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I94f17b81f845fa94599f93c0be1144ffcb8e4165 </div>
<div style="display:none"> Gerrit-Change-Number: 29153 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>