[coreboot-gerrit] Change in coreboot[master]: ec/google/wilco: Add SMM handlers

Duncan Laurie (Code Review) gerrit at coreboot.org
Tue Oct 16 00:54:34 CEST 2018


Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/29119


Change subject: ec/google/wilco: Add SMM handlers
......................................................................

ec/google/wilco: Add SMM handlers

Add EC handlers for specific SMM actions:

- on entry to sleep state tell the EC to save state and to prepare for
the host to enter sleep
- on ACPI enable/disable send command to the EC
- add a function to print SMI reasons when eSPI SMI is received

These need to be called by the mainboard handlers which will be done
when a board is added that uses this EC.

Change-Id: Ibabdc1462e0a8df405f9520244b83684e2ccf2f5
Signed-off-by: Duncan Laurie <dlaurie at google.com>
---
M src/ec/google/wilco/Makefile.inc
A src/ec/google/wilco/smihandler.c
A src/ec/google/wilco/smm.h
3 files changed, 83 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/29119/1

diff --git a/src/ec/google/wilco/Makefile.inc b/src/ec/google/wilco/Makefile.inc
index c011ebf..33eefd5 100644
--- a/src/ec/google/wilco/Makefile.inc
+++ b/src/ec/google/wilco/Makefile.inc
@@ -1,5 +1,6 @@
 ifeq ($(CONFIG_EC_GOOGLE_WILCO),y)
 
 ramstage-y += chip.c commands.c mailbox.c
+smm-y += commands.c mailbox.c smihandler.c
 
 endif
diff --git a/src/ec/google/wilco/smihandler.c b/src/ec/google/wilco/smihandler.c
new file mode 100644
index 0000000..9fb1518
--- /dev/null
+++ b/src/ec/google/wilco/smihandler.c
@@ -0,0 +1,59 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 Google LLC
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <arch/acpi.h>
+#include <console/console.h>
+#include <cpu/x86/smm.h>
+
+#include "commands.h"
+#include "ec.h"
+#include "smm.h"
+
+void wilco_ec_smi_sleep(int slp_type)
+{
+	switch (slp_type) {
+	case ACPI_S3:
+		wilco_ec_slp_en();
+		break;
+	case ACPI_S5:
+		wilco_ec_power_off(EC_SWOFF_ACPI);
+		break;
+	}
+}
+
+void wilco_ec_smi_apmc(int apmc)
+{
+	switch (apmc) {
+	case APM_CNT_ACPI_ENABLE:
+		wilco_ec_send(KB_ACPI, ACPI_ON);
+		break;
+	case APM_CNT_ACPI_DISABLE:
+		wilco_ec_send(KB_ACPI, ACPI_OFF);
+		break;
+	}
+}
+
+void wilco_ec_smi_espi(void)
+{
+	struct ec_pm_event_state pm;
+
+	if (!wilco_ec_power_smi(&pm)) {
+		printk(BIOS_INFO,
+		       "EC SMI: %02x_%02x-%02x_%02x_%02x_%02x_%02x_%02x-%02x",
+		       pm.event[0], pm.event[1],
+		       pm.state[0], pm.state[1], pm.state[2],
+		       pm.state[3], pm.state[4], pm.state[5], pm.hotkey);
+	}
+}
diff --git a/src/ec/google/wilco/smm.h b/src/ec/google/wilco/smm.h
new file mode 100644
index 0000000..1798b79
--- /dev/null
+++ b/src/ec/google/wilco/smm.h
@@ -0,0 +1,23 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 Google LLC
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef EC_GOOGLE_WILCO_SMM_H
+#define EC_GOOGLE_WILCO_SMM_H
+
+void wilco_ec_smi_sleep(int slp_type);
+void wilco_ec_smi_apmc(int apmc);
+void wilco_ec_smi_espi(void);
+
+#endif /* EC_GOOGLE_WILCO_SMM_H */

-- 
To view, visit https://review.coreboot.org/29119
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibabdc1462e0a8df405f9520244b83684e2ccf2f5
Gerrit-Change-Number: 29119
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181015/eb432190/attachment-0001.html>


More information about the coreboot-gerrit mailing list