<p>Duncan Laurie has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/29119">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ec/google/wilco: Add SMM handlers<br><br>Add EC handlers for specific SMM actions:<br><br>- on entry to sleep state tell the EC to save state and to prepare for<br>the host to enter sleep<br>- on ACPI enable/disable send command to the EC<br>- add a function to print SMI reasons when eSPI SMI is received<br><br>These need to be called by the mainboard handlers which will be done<br>when a board is added that uses this EC.<br><br>Change-Id: Ibabdc1462e0a8df405f9520244b83684e2ccf2f5<br>Signed-off-by: Duncan Laurie <dlaurie@google.com><br>---<br>M src/ec/google/wilco/Makefile.inc<br>A src/ec/google/wilco/smihandler.c<br>A src/ec/google/wilco/smm.h<br>3 files changed, 83 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/29119/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ec/google/wilco/Makefile.inc b/src/ec/google/wilco/Makefile.inc</span><br><span>index c011ebf..33eefd5 100644</span><br><span>--- a/src/ec/google/wilco/Makefile.inc</span><br><span>+++ b/src/ec/google/wilco/Makefile.inc</span><br><span>@@ -1,5 +1,6 @@</span><br><span> ifeq ($(CONFIG_EC_GOOGLE_WILCO),y)</span><br><span> </span><br><span> ramstage-y += chip.c commands.c mailbox.c</span><br><span style="color: hsl(120, 100%, 40%);">+smm-y += commands.c mailbox.c smihandler.c</span><br><span> </span><br><span> endif</span><br><span>diff --git a/src/ec/google/wilco/smihandler.c b/src/ec/google/wilco/smihandler.c</span><br><span>new file mode 100644</span><br><span>index 0000000..9fb1518</span><br><span>--- /dev/null</span><br><span>+++ b/src/ec/google/wilco/smihandler.c</span><br><span>@@ -0,0 +1,59 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright 2018 Google LLC</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <arch/acpi.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <console/console.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <cpu/x86/smm.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include "commands.h"</span><br><span style="color: hsl(120, 100%, 40%);">+#include "ec.h"</span><br><span style="color: hsl(120, 100%, 40%);">+#include "smm.h"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+void wilco_ec_smi_sleep(int slp_type)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (slp_type) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case ACPI_S3:</span><br><span style="color: hsl(120, 100%, 40%);">+ wilco_ec_slp_en();</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case ACPI_S5:</span><br><span style="color: hsl(120, 100%, 40%);">+ wilco_ec_power_off(EC_SWOFF_ACPI);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+void wilco_ec_smi_apmc(int apmc)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (apmc) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case APM_CNT_ACPI_ENABLE:</span><br><span style="color: hsl(120, 100%, 40%);">+ wilco_ec_send(KB_ACPI, ACPI_ON);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case APM_CNT_ACPI_DISABLE:</span><br><span style="color: hsl(120, 100%, 40%);">+ wilco_ec_send(KB_ACPI, ACPI_OFF);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+void wilco_ec_smi_espi(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct ec_pm_event_state pm;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!wilco_ec_power_smi(&pm)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+ "EC SMI: %02x_%02x-%02x_%02x_%02x_%02x_%02x_%02x-%02x",</span><br><span style="color: hsl(120, 100%, 40%);">+ pm.event[0], pm.event[1],</span><br><span style="color: hsl(120, 100%, 40%);">+ pm.state[0], pm.state[1], pm.state[2],</span><br><span style="color: hsl(120, 100%, 40%);">+ pm.state[3], pm.state[4], pm.state[5], pm.hotkey);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>diff --git a/src/ec/google/wilco/smm.h b/src/ec/google/wilco/smm.h</span><br><span>new file mode 100644</span><br><span>index 0000000..1798b79</span><br><span>--- /dev/null</span><br><span>+++ b/src/ec/google/wilco/smm.h</span><br><span>@@ -0,0 +1,23 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright 2018 Google LLC</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#ifndef EC_GOOGLE_WILCO_SMM_H</span><br><span style="color: hsl(120, 100%, 40%);">+#define EC_GOOGLE_WILCO_SMM_H</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+void wilco_ec_smi_sleep(int slp_type);</span><br><span style="color: hsl(120, 100%, 40%);">+void wilco_ec_smi_apmc(int apmc);</span><br><span style="color: hsl(120, 100%, 40%);">+void wilco_ec_smi_espi(void);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#endif /* EC_GOOGLE_WILCO_SMM_H */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/29119">change 29119</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29119"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ibabdc1462e0a8df405f9520244b83684e2ccf2f5 </div>
<div style="display:none"> Gerrit-Change-Number: 29119 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>